Remove unused EnableAdviewSrcAttribute command line flag.

chrome/renderer/resources/extensions/ad_view.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Shim that simulates a <adview> tag via Mutation Observers.
 //
 // The actual tag is implemented via the browser plugin. The internals of this
 // are hidden via Shadow DOM.
 
 // TODO(rpaquay): This file is currently very similar to "web_view.js". Do we
 //                want to refactor to extract common pieces?
 
 var eventBindings = require('event_bindings');
 var process = requireNative('process');
 var addTagWatcher = require('tagWatcher').addTagWatcher;
 
 /**
- * Define "allowCustomAdNetworks" function such that the
- * "kEnableAdviewSrcAttribute" flag is respected.
- */
-function allowCustomAdNetworks() {
-  return process.HasSwitch('enable-adview-src-attribute');
-}
-
-/**
  * List of attribute names to "blindly" sync between <adview> tag and internal
  * browser plugin.
  */
 var AD_VIEW_ATTRIBUTES = [
   'name',
 ];
 
 /**
  * List of custom attributes (and their behavior).
  *
  * name: attribute name.
  * onMutation(adview, mutation): callback invoked when attribute is mutated.
  * isProperty: True if the attribute should be exposed as a property.
  */
 var AD_VIEW_CUSTOM_ATTRIBUTES = [
   {
     name: 'ad-network',
     onMutation: function(adview, mutation) {
       adview.handleAdNetworkMutation(mutation);
     },
     isProperty: function() {
       return true;
     }
-  },
-  {
-    name: 'src',
-    onMutation: function(adview, mutation) {
-      adview.handleSrcMutation(mutation);
-    },
-    isProperty: function() {
-      return allowCustomAdNetworks();
-    }
   }
 ];
 
 /**
  * List of api methods. These are forwarded to the browser plugin.
  */
 var AD_VIEW_API_METHODS = [
  // Empty for now.
 ];
 
 var createEvent = function(name) {
   var eventOpts = {supportsListeners: true, supportsFilters: true};
   return new eventBindings.Event(name, undefined, eventOpts);
 };
 
 var AdviewLoadAbortEvent = createEvent('adview.onLoadAbort');
 var AdviewLoadCommitEvent = createEvent('adview.onLoadCommit');
 
 var AD_VIEW_EXT_EVENTS = {
   'loadabort': {
     evt: AdviewLoadAbortEvent,
     fields: ['url', 'isTopLevel', 'reason']
   },
   'loadcommit': {
-    customHandler: function(adview, event) {
-      if (event.isTopLevel) {
-        adview.browserPluginNode_.setAttribute('src', event.url);
-      }
-    },
     evt: AdviewLoadCommitEvent,
     fields: ['url', 'isTopLevel']
   }
 };
 
 /**
  * List of supported ad-networks.
  *
  * name: identifier of the ad-network, corresponding to a valid value
  *       of the "ad-network" attribute of an <adview> element.
@@ skipping 240 matching lines @@
     // if the BrowserPlugin attributes differs from it.
     var oldValue = this.adviewNode_.getAttribute(mutation.attributeName);
     var newValue = this.browserPluginNode_.getAttribute(mutation.attributeName);
     if (newValue != oldValue) {
       this.adviewNode_.setAttribute(mutation.attributeName, newValue);
     }
   }
 };
 
 /**
- * @private
- */
-AdView.prototype.navigateToUrl_ = function(url) {
-  var newValue = url;
-  var oldValue = this.browserPluginNode_.getAttribute('src');
-
-  if (newValue === oldValue)
-    return;
-
-  if (url != null) {
-    // Note: Setting the 'src' property directly, as calling setAttribute has no
-    // effect due to implementation details of BrowserPlugin.
-    this.browserPluginNode_['src'] = url;
-    if (allowCustomAdNetworks()) {
-      this.adviewNode_.setAttribute('src', url);
-    }
-  }
-  else {
-    // Note: Setting the 'src' property directly, as calling setAttribute has no
-    // effect due to implementation details of BrowserPlugin.
-    // TODO(rpaquay): Due to another implementation detail of BrowserPlugin,
-    // this line will leave the "src" attribute value untouched.
-    this.browserPluginNode_['src'] = null;
-    if (allowCustomAdNetworks()) {
-      this.adviewNode_.removeAttribute('src');
-    }
-  }
-}
-
-/**
  * @public
  */
 AdView.prototype.handleAdNetworkMutation = function(mutation) {
   if (this.adviewNode_.hasAttribute('ad-network')) {
     var value = this.adviewNode_.getAttribute('ad-network');
     var item = getAdNetworkInfo(value);
-    if (item) {
-      this.navigateToUrl_(item.url);
-    }
-    else if (allowCustomAdNetworks()) {
-      console.log('The ad-network "' + value + '" is not recognized, ' +
-        'but custom ad-networks are enabled.');
-
-      if (mutation) {
-        this.navigateToUrl_('');
-      }
-    }
-    else {
+    if (!item) {
       // Ignore the new attribute value and set it to empty string.
       // Avoid infinite loop by checking for empty string as new value.
       if (value != '') {
         console.error('The ad-network "' + value + '" is not recognized.');
         this.adviewNode_.setAttribute('ad-network', '');
       }
-      this.navigateToUrl_('');
-    }
-  }
-  else {
-    this.navigateToUrl_('');
-  }
-}
-
-/**
- * @public
- */
-AdView.prototype.handleSrcMutation = function(mutation) {
-  if (allowCustomAdNetworks()) {
-    if (this.adviewNode_.hasAttribute('src')) {
-      var newValue = this.adviewNode_.getAttribute('src');
-      // Note: Setting the 'src' property directly, as calling setAttribute has
-      // no effect due to implementation details of BrowserPlugin.
-      this.browserPluginNode_['src'] = newValue;
-    }
-    else {
-      // If an attribute is removed from the <adview>, then remove it
-      // from the BrowserPlugin as well.
-      // Note: Setting the 'src' property directly, as calling setAttribute has
-      // no effect due to implementation details of BrowserPlugin.
-      // TODO(rpaquay): Due to another implementation detail of BrowserPlugin,
-      // this line will leave the "src" attribute value untouched.
-      this.browserPluginNode_['src'] = null;
-    }
-  }
-  else {
-    if (this.adviewNode_.hasAttribute('src')) {
-      var value = this.adviewNode_.getAttribute('src');
-      // Ignore the new attribute value and set it to empty string.
-      // Avoid infinite loop by checking for empty string as new value.
-      if (value != '') {
-        console.error('Setting the "src" attribute of an <adview> ' +
-          'element is not supported.  Use the "ad-network" attribute ' +
-          'instead.');
-        this.adviewNode_.setAttribute('src', '');
-      }
     }
   }
 }
 
 /**
  * @private
  */
 AdView.prototype.setupAdviewNodeEvents_ = function() {
   var self = this;
   var onInstanceIdAllocated = function(e) {
@@ skipping 38 matching lines @@
   var evt = new Event(eventname, { bubbles: true });
   for(var item in detail) {
       evt[item] = detail[item];
   }
 
   // Dispatch event.
   this.adviewNode_.dispatchEvent(evt);
 }
 
 addTagWatcher('ADVIEW', function(addedNode) { new AdView(addedNode); });