Remove unused EnableAdviewSrcAttribute command line flag.

Remove unused EnableAdviewSrcAttribute.

BUG=315414
TEST=affected tests removed

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247950

[pastarmovj, 2014-01-27 12:53:15]

Looks fine to me! Please run a couple of try bots on it to see if there are no
other tests that might depend on this switch and I'll stamp it.

[Thiemo Nagel, 2014-01-27 13:47:46]

Hi Renaud,

I'm a Noogler from Munich, this is the first bug assigned to me. I've added you
because you've written the adview code, as far as I can see. Removing
EnableAdviewSrcAttribute simplifies some parts, especially isProperty of 'src'
now always returns false. Therefore I'm wondering, whether I can remove
adview.handleSrcMutation() altogether. What do you think?

Thank you,
Thiemo

[rpaquay, 2014-01-27 16:57:30]

On 2014/01/27 13:47:46, tnagel wrote:
> Hi Renaud,
> 
> I'm a Noogler from Munich, this is the first bug assigned to me. I've added
you
> because you've written the adview code, as far as I can see. Removing
> EnableAdviewSrcAttribute simplifies some parts, especially isProperty of 'src'
> now always returns false. Therefore I'm wondering, whether I can remove
> adview.handleSrcMutation() altogether. What do you think?
> 
> Thank you,
> Thiemo

sgtm. You should be able to remove the entire "src" entry from the
AD_VIEW_CUSTOM_ATTRIBUTES dictionary.

[Thiemo Nagel, 2014-01-28 14:20:16]

> sgtm. You should be able to remove the entire "src" entry from the
> AD_VIEW_CUSTOM_ATTRIBUTES dictionary.

Several tests are failing (also for patch set 1), cf. below.  Probably test
failure #4 can be fixed by updating the test.  However, as far as I can see,
failures #1-#3 are directly related to removal of 'src' -- they depend on 'src'.
 Are we really sure, we want to remove 'src'?  Then we'll have to remove these
tests, too.

1. CommitMessageFromAdNetwork (onloadcommit_ack)

// This test checks the page loaded inside an <adview> has the ability to
// 1) receive "message" events from the application, and 2) use
// "window.postMessage" to post back a message to the application.

2. LoadAbortEventIsCalled (loadabort_event)

// This test checks the "loadabort" event is called when the "src" attribute
// of an <adview> is an invalid URL.

3. LoadCommitEventIsCalled (loadcommit_event)

// This test checks the "loadcommit" event is called when the page inside an
// <adview> is loaded.

4. PropertiesAreInSyncWithAttributes (properties_exposed)

// This test checks that <adview> attributes are also exposed as properties
// (with the same name and value).

[rpaquay, 2014-01-28 21:53:39]

On 2014/01/28 14:20:16, tnagel wrote:
> > sgtm. You should be able to remove the entire "src" entry from the
> > AD_VIEW_CUSTOM_ATTRIBUTES dictionary.
> 
> Several tests are failing (also for patch set 1), cf. below.  Probably test
> failure #4 can be fixed by updating the test.  However, as far as I can see,
> failures #1-#3 are directly related to removal of 'src' -- they depend on
'src'.
>  Are we really sure, we want to remove 'src'?  Then we'll have to remove these
> tests, too.
> 
> 1. CommitMessageFromAdNetwork (onloadcommit_ack)
> 
> // This test checks the page loaded inside an <adview> has the ability to
> // 1) receive "message" events from the application, and 2) use
> // "window.postMessage" to post back a message to the application.
> 
> 2. LoadAbortEventIsCalled (loadabort_event)
> 
> // This test checks the "loadabort" event is called when the "src" attribute
> // of an <adview> is an invalid URL.
> 
> 3. LoadCommitEventIsCalled (loadcommit_event)
> 
> // This test checks the "loadcommit" event is called when the page inside an
> // <adview> is loaded.
> 
> 4. PropertiesAreInSyncWithAttributes (properties_exposed)
> 
> // This test checks that <adview> attributes are also exposed as properties
> // (with the same name and value).

Yeah, it is fine to delete the tests too.

[Thiemo Nagel, 2014-01-29 15:39:08]

Hi Fady,

could you please take a look at this CL? Following advice by Renaud, I've
removed all tests that depend on the flag, too. (The remaining tests pass.)

Thank you and best regards,
Thiemo

[Fady Samuel, 2014-01-29 15:47:11]

lgtm

[commit-bot: I haz the power, 2014-01-29 16:20:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tnagel@chromium.org/147663002/270001

[commit-bot: I haz the power, 2014-01-29 16:22:26]

CQ bit was unchecked on CL. Ignoring.

[Thiemo Nagel, 2014-01-29 16:28:14]

Hi Renaud,

could you please be so kind to take a final look before I commit?

Thank you,
Thiemo

[rpaquay, 2014-01-30 02:32:49]

On 2014/01/29 16:28:14, Thiemo Nagel wrote:
> Hi Renaud,
> 
> could you please be so kind to take a final look before I commit?
> 
> Thank you,
> Thiemo

lgtm

[commit-bot: I haz the power, 2014-01-30 09:43:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tnagel@chromium.org/147663002/270001

[commit-bot: I haz the power, 2014-01-30 13:47:10]

Change committed as 247950