Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1476563002: Remove SkDrawProcs (Closed)

Created:
5 years ago by herb_g
Modified:
5 years ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove decl #

Patch Set 3 : remove include #

Patch Set 4 : add back skdraw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -117 lines) Patch
M include/core/SkDraw.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkDraw.cpp View 1 2 6 chunks +51 lines, -41 lines 0 comments Download
M src/core/SkDrawProcs.h View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 9 chunks +7 lines, -22 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
herb_g
remove decl
5 years ago (2015-11-24 18:03:59 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476563002/20001
5 years ago (2015-11-24 18:04:26 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 18:17:36 UTC) #7
herb_g
remove include
5 years ago (2015-11-24 19:39:06 UTC) #8
herb_g
add back skdraw
5 years ago (2015-11-24 19:41:35 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476563002/60001
5 years ago (2015-11-24 19:42:05 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 19:59:43 UTC) #13
herb_g
5 years ago (2015-11-24 20:00:03 UTC) #14
bungeman-skia
lgtm
5 years ago (2015-11-24 20:16:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476563002/60001
5 years ago (2015-11-24 20:27:11 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/4245)
5 years ago (2015-11-24 20:28:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476563002/60001
5 years ago (2015-11-24 20:40:26 UTC) #23
commit-bot: I haz the power
5 years ago (2015-11-24 20:41:03 UTC) #24
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/11a7f7f5998cb3d5605741e37a7f12f7477d480c

Powered by Google App Engine
This is Rietveld 408576698