Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 147653002: previousRegionLogicalHeight not getting updated (Closed)

Created:
6 years, 11 months ago by rhogan
Modified:
6 years, 8 months ago
CC:
blink-reviews, chromiumbugtracker_adobe.com, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, eseidel
Visibility:
Public.

Description

previousRegionLogicalHeight not getting updated previousRegionLogicalHeight() was not getting updated in RenderFlowThread::validateRegions() and previousRegionLogicalWidth() was updated but not used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170589

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated for Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/rendering/RenderFlowThread.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rhogan
6 years, 10 months ago (2014-01-29 19:31:14 UTC) #1
Julien - ping for review
lgtm +Mihnea as it probably interest him. Let's remove the empty BUG= from the description ...
6 years, 9 months ago (2014-03-26 00:13:43 UTC) #2
mihnea
On 2014/03/26 00:13:43, Julien Chaffraix - PST wrote: > lgtm > > +Mihnea as it ...
6 years, 9 months ago (2014-03-28 14:56:04 UTC) #3
rhogan
The CQ bit was checked by robhogan@gmail.com
6 years, 8 months ago (2014-04-01 17:29:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/147653002/50001
6 years, 8 months ago (2014-04-01 17:29:53 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 18:16:47 UTC) #6
Message was sent while issue was closed.
Change committed as 170589

Powered by Google App Engine
This is Rietveld 408576698