content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc - Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc

Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: halliwell@ comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/media_stream_remote_video_source.cc ('k') | content/renderer/pepper/content_decryptor_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc

diff --git a/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc b/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc

index c3b407b48a5fe3ef4694fb4dd1a53c7cc0eb5936..abdb1b17fa9a531446f447b85df2d7cf12b12ec1 100644

--- a/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc

+++ b/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc

@@ -95,6 +95,8 @@ class WebRtcVideoCapturerAdapter::MediaVideoFrameFactory

const gfx::Size output_size(output_width, output_height);

scoped_refptr<media::VideoFrame> video_frame =

media::VideoFrame::WrapVideoFrame(frame_, visible_rect, output_size);

+ if (!video_frame)

+ return nullptr;

video_frame->AddDestructionObserver(

base::Bind(&ReleaseOriginalFrame, frame_));