content/renderer/media/video_capture_impl.cc - Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/video_capture_impl.cc

Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: halliwell@ comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/video_capture_impl.cc

diff --git a/content/renderer/media/video_capture_impl.cc b/content/renderer/media/video_capture_impl.cc

index aa06bd7222a63767433c50912ae1a8c8bd928937..8e50ede0063a8041bb7c5d9b60d4ef2ffc6ac061 100644

--- a/content/renderer/media/video_capture_impl.cc

+++ b/content/renderer/media/video_capture_impl.cc

@@ -374,7 +374,11 @@ void VideoCaptureImpl::OnBufferReceived(

NOTREACHED();

break;

}

- DCHECK(frame);

+ if (!frame) {

+ Send(new VideoCaptureHostMsg_BufferReady(device_id_, buffer_id,

+ gpu::SyncToken(), -1.0));

+ return;

+ }

frame->metadata()->SetTimeTicks(media::VideoFrameMetadata::REFERENCE_TIME,

timestamp);

« no previous file with comments | « content/renderer/media/rtc_video_decoder.cc ('k') | content/renderer/media/video_track_adapter.cc » ('j') | no next file with comments »