chromecast/renderer/media/hole_frame_factory.cc - Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/renderer/media/hole_frame_factory.cc

Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/trees/layer_tree_host_unittest_context.cc ('k') | content/browser/renderer_host/media/video_capture_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/renderer/media/hole_frame_factory.cc

diff --git a/chromecast/renderer/media/hole_frame_factory.cc b/chromecast/renderer/media/hole_frame_factory.cc

index c4f26e6c8402454751165e90ce244f6907ccee00..0dda172a4c84c5348686143955f0760e4d4dcd8c 100644

--- a/chromecast/renderer/media/hole_frame_factory.cc

+++ b/chromecast/renderer/media/hole_frame_factory.cc

@@ -64,6 +64,8 @@ scoped_refptr<::media::VideoFrame> HoleFrameFactory::CreateHoleFrame(

gfx::Rect(size), // visible rect

size, // natural size

base::TimeDelta()); // timestamp

+ if (!frame)

+ return nullptr;

halliwell 2016/01/15 01:52:04 I'm not sure how useful this is. If there is a pr

emircan 2016/01/15 02:04:10 Done.

frame->metadata()->SetBoolean(::media::VideoFrameMetadata::ALLOW_OVERLAY,

true);

return frame;