content/common/gpu/media/v4l2_image_processor.cc - Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_image_processor.cc

Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mcasas@ comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/gpu_video_encode_accelerator.cc ('k') | content/common/gpu/media/video_encode_accelerator_unittest.cc » ('j') | media/base/video_frame.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/v4l2_image_processor.cc

diff --git a/content/common/gpu/media/v4l2_image_processor.cc b/content/common/gpu/media/v4l2_image_processor.cc

index 2e500146ab8310fd8f927daedfbfa81f4aefbc68..c501c926e0c4142cdd4d8cad4dfd3bfe7d2b5167 100644

--- a/content/common/gpu/media/v4l2_image_processor.cc

+++ b/content/common/gpu/media/v4l2_image_processor.cc

@@ -561,6 +561,8 @@ void V4L2ImageProcessor::Dequeue() {

output_visible_size_,

output_record.fds,

job_record->frame->timestamp());

+ if (!output_frame)

+ continue;

Pawel Osciak 2016/01/13 07:53:25 We should NOTIFY_ERROR from here instead. Otherwis

emircan 2016/01/14 23:13:53 Changing to NOTIFY_ERROR and return. The logs woul

output_frame->AddDestructionObserver(media::BindToCurrentLoop(

base::Bind(&V4L2ImageProcessor::ReuseOutputBuffer,

device_weak_factory_.GetWeakPtr(),