content/renderer/pepper/pepper_media_stream_video_track_host.cc - Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_media_stream_video_track_host.cc

Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/rtc_video_decoder.cc ('K') | « content/renderer/pepper/content_decryptor_delegate.cc ('k') | content/renderer/pepper/pepper_video_encoder_host.cc » ('j') | content/renderer/pepper/pepper_video_encoder_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_media_stream_video_track_host.cc

diff --git a/content/renderer/pepper/pepper_media_stream_video_track_host.cc b/content/renderer/pepper/pepper_media_stream_video_track_host.cc

index 2e7e2c2363c87d2ab0c916eeeb152ad4ee08de2a..5f7ff619c03d9f83b22220e1362b7988356aa74c 100644

--- a/content/renderer/pepper/pepper_media_stream_video_track_host.cc

+++ b/content/renderer/pepper/pepper_media_stream_video_track_host.cc

@@ -355,7 +355,8 @@ int32_t PepperMediaStreamVideoTrackHost::SendFrameToTrack(int32_t index) {

u_data,

v_data,

base::TimeDelta::FromMilliseconds(ts_ms));

+ if (!frame)

+ return PP_ERROR_FAILED;

frame_deliverer_->DeliverVideoFrame(frame);

Pawel Osciak 2015/11/26 01:19:03 Please empty line above.

emircan 2015/12/04 04:20:09 Done.

}