Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: media/capture/content/thread_safe_capture_oracle.cc

Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: LOG in video_Frame and CHECK/return outside. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/content/thread_safe_capture_oracle.cc
diff --git a/media/capture/content/thread_safe_capture_oracle.cc b/media/capture/content/thread_safe_capture_oracle.cc
index 0c62e697e54f93cb009eb71215227817dfcd7210..af78616caa4a346b900b4c748b65126020348a5b 100644
--- a/media/capture/content/thread_safe_capture_oracle.cc
+++ b/media/capture/content/thread_safe_capture_oracle.cc
@@ -120,7 +120,8 @@ bool ThreadSafeCaptureOracle::ObserveEventAndDecideCapture(
gfx::Rect(visible_size), visible_size,
static_cast<uint8*>(output_buffer->data()), output_buffer->mapped_size(),
base::SharedMemory::NULLHandle(), 0u, base::TimeDelta());
- DCHECK(*storage);
+ if (!(*storage))
+ return false;
*callback =
base::Bind(&ThreadSafeCaptureOracle::DidCaptureFrame, this, frame_number,
base::Passed(&output_buffer), capture_begin_time,

Powered by Google App Engine
This is Rietveld 408576698