content/renderer/media/webrtc/media_stream_remote_video_source.cc - Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/media_stream_remote_video_source.cc

Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: LOG in video_Frame and CHECK/return outside. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/resources/video_resource_updater_unittest.cc ('K') | « content/renderer/media/video_track_adapter.cc ('k') | content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/media_stream_remote_video_source.cc

diff --git a/content/renderer/media/webrtc/media_stream_remote_video_source.cc b/content/renderer/media/webrtc/media_stream_remote_video_source.cc

index 501eaefdb241b427cc99b9b8b03b8e73d220003e..54150623c5a8ce4e8c385e2a9f0f2e525e292163 100644

--- a/content/renderer/media/webrtc/media_stream_remote_video_source.cc

+++ b/content/renderer/media/webrtc/media_stream_remote_video_source.cc

@@ -116,6 +116,8 @@ void MediaStreamRemoteVideoSource::RemoteVideoSourceDelegate::RenderFrame(

const_cast<uint8_t*>(frame->GetYPlane()),

const_cast<uint8_t*>(frame->GetUPlane()),

const_cast<uint8_t*>(frame->GetVPlane()), elapsed_timestamp);

+ if (!video_frame)

+ return;

video_frame->AddDestructionObserver(

base::Bind(&base::DeletePointer<cricket::VideoFrame>, frame->Copy()));

}