cc/trees/layer_tree_host_unittest_context.cc - Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_unittest_context.cc

Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: LOG in video_Frame and CHECK/return outside. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/resources/video_resource_updater_unittest.cc ('K') | « cc/resources/video_resource_updater_unittest.cc ('k') | chromecast/renderer/media/hole_frame_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/trees/layer_tree_host_unittest_context.cc

diff --git a/cc/trees/layer_tree_host_unittest_context.cc b/cc/trees/layer_tree_host_unittest_context.cc

index 8c5dd8aa544faf4d37b8d3bb4efe87318a1d3dd6..4ab392489f98715ffe27e1eda664cad44765ca42 100644

--- a/cc/trees/layer_tree_host_unittest_context.cc

+++ b/cc/trees/layer_tree_host_unittest_context.cc

@@ -1015,16 +1015,19 @@ class LayerTreeHostContextTestDontUseLostResources

color_video_frame_ = VideoFrame::CreateColorFrame(

gfx::Size(4, 4), 0x80, 0x80, 0x80, base::TimeDelta());

+ CHECK(color_video_frame_);

hw_video_frame_ = VideoFrame::WrapNativeTexture(

media::PIXEL_FORMAT_ARGB,

gpu::MailboxHolder(mailbox, sync_token, GL_TEXTURE_2D),

media::VideoFrame::ReleaseMailboxCB(), gfx::Size(4, 4),

gfx::Rect(0, 0, 4, 4), gfx::Size(4, 4), base::TimeDelta());

+ CHECK(hw_video_frame_);

scaled_hw_video_frame_ = VideoFrame::WrapNativeTexture(

media::PIXEL_FORMAT_ARGB,

gpu::MailboxHolder(mailbox, sync_token, GL_TEXTURE_2D),

media::VideoFrame::ReleaseMailboxCB(), gfx::Size(4, 4),

gfx::Rect(0, 0, 3, 2), gfx::Size(4, 4), base::TimeDelta());

+ CHECK(scaled_hw_video_frame_);

color_frame_provider_.set_frame(color_video_frame_);

hw_frame_provider_.set_frame(hw_video_frame_);