Verify returned frames from media::VideoFrame::Wrap*() methods

content/common/gpu/media/gpu_jpeg_decode_accelerator.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/gpu_jpeg_decode_accelerator.h"
 
 #include <stdint.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 230 matching lines @@
         media::VideoFrame::WrapExternalSharedMemory(
             media::PIXEL_FORMAT_I420,          // format
             params.coded_size,                 // coded_size
             gfx::Rect(params.coded_size),      // visible_rect
             params.coded_size,                 // natural_size
             shm_memory,                        // data
             params.output_buffer_size,         // data_size
             params.output_video_frame_handle,  // handle
             0,                                 // data_offset
             base::TimeDelta());                // timestamp
-    frame->AddDestructionObserver(
-        base::Bind(DecodeFinished, base::Passed(&output_shm)));
-
     if (!frame.get()) {
       LOG(ERROR) << "Could not create VideoFrame for input buffer id "
                  << params.input_buffer_id;
       NotifyDecodeStatusOnIOThread(
           *route_id, params.input_buffer_id,
           media::JpegDecodeAccelerator::PLATFORM_FAILURE);
       base::SharedMemory::CloseHandle(params.input_buffer_handle);
       return;
     }
+    frame->AddDestructionObserver(
+        base::Bind(DecodeFinished, base::Passed(&output_shm)));

[mcasas, 2016/01/12 17:46:16]

nit: s/base::Passed/std::move/

[emircan, 2016/01/14 23:07:40]

It causes a compile error as it is inside a base::Bind statement.

 
     DCHECK_GT(client_map_.count(*route_id), 0u);
     Client* client = client_map_[*route_id];
     client->Decode(input_buffer, frame);
   }
 
  protected:
   ~MessageFilter() override {
     if (client_map_.empty())
       return;
@@ skipping 160 matching lines @@
   for (const auto& create_jda_function : create_jda_fps) {
     scoped_ptr<media::JpegDecodeAccelerator> accelerator =
         (*create_jda_function)(base::ThreadTaskRunnerHandle::Get());
     if (accelerator && accelerator->IsSupported())
       return true;
   }
   return false;
 }
 
 }  // namespace content