Verify returned frames from media::VideoFrame::Wrap*() methods

content/common/gpu/media/gpu_video_encode_accelerator.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/gpu_video_encode_accelerator.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/shared_memory.h"
@@ skipping 258 matching lines @@
       media::VideoFrame::WrapExternalSharedMemory(
           input_format_,
           input_coded_size_,
           gfx::Rect(input_visible_size_),
           input_visible_size_,
           shm_memory,
           params.buffer_size,
           params.buffer_handle,
           params.buffer_offset,
           base::TimeDelta());
+  if (!frame.get()) {

[Pawel Osciak, 2015/11/26 01:19:03]

if (!frame) ?

[emircan, 2015/12/04 04:20:09]

Done.

+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncode(): could not create "
+                   "VideoFrame for frame_id=" << params.frame_id;

[Pawel Osciak, 2015/11/26 01:19:03]

s/"Video/<< "Video/

[emircan, 2015/12/04 04:20:09]

Done.

+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
   frame->AddDestructionObserver(
       media::BindToCurrentLoop(
           base::Bind(&GpuVideoEncodeAccelerator::EncodeFrameFinished,
                      weak_this_factory_.GetWeakPtr(),
                      params.frame_id,
                      base::Passed(&shm))));
 
-  if (!frame.get()) {
-    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncode(): could not create "
-                   "VideoFrame for frame_id=" << params.frame_id;
-    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
-    return;
-  }
-
   encoder_->Encode(frame, params.force_keyframe);
 }
 
 void GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(
     int32 buffer_id,
     base::SharedMemoryHandle buffer_handle,
     uint32 buffer_size) {
   DVLOG(3) << "GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(): "
               "buffer_id=" << buffer_id
            << ", buffer_size=" << buffer_size;
@@ skipping 43 matching lines @@
   stub_->channel()->Send(message);
 }
 
 void GpuVideoEncodeAccelerator::SendCreateEncoderReply(IPC::Message* message,
                                                        bool succeeded) {
   GpuCommandBufferMsg_CreateVideoEncoder::WriteReplyParams(message, succeeded);
   Send(message);
 }
 
 }  // namespace content