components/password_manager/core/browser/password_manager.cc - Issue 1476523004: Implementation of new behaviour of Password Manager on retry password forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1476523004: Implementation of new behaviour of Password Manager on retry password forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments updated Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager.cc ('K') | « components/password_manager/core/browser/password_form_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index cf7d0d3a16721dc6dcbbe4f3805d26bede8dc543..e1e15dd02e3a845c574be42ad228ee7aba757841 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -559,6 +559,7 @@ bool PasswordManager::ShouldPromptUserToSavePassword() const {

(provisional_save_manager_->IsNewLogin() ||

provisional_save_manager_

->is_possible_change_password_form_without_username() ||

+ provisional_save_manager_->retry_password_form_password_update() ||

(provisional_save_manager_->password_overridden() &&

client_->IsUpdatePasswordUIEnabled())) &&

!provisional_save_manager_->has_generated_password() &&

@@ -697,7 +698,8 @@ void PasswordManager::OnLoginSuccessful() {

(!provisional_save_manager_->best_matches().empty() &&

provisional_save_manager_

->is_possible_change_password_form_without_username()) ||

- provisional_save_manager_->password_overridden();

+ provisional_save_manager_->password_overridden() ||

+ provisional_save_manager_->retry_password_form_password_update();

if (client_->PromptUserToSaveOrUpdatePassword(

provisional_save_manager_.Pass(),

CredentialSourceType::CREDENTIAL_SOURCE_PASSWORD_MANAGER,