Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 1476523002: Stop normalizing path data for layout tree text output (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop normalizing path data for layout tree text output BUG=467592 Committed: https://crrev.com/6472368bac3c0c37507635022896a9eecf2ed032 Cr-Commit-Position: refs/heads/master@{#361873}

Patch Set 1 #

Patch Set 2 : TEs #

Patch Set 3 : Better re-enable references #

Patch Set 4 : More TEs #

Patch Set 5 : Updated TEs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 6 chunks +128 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
fs
Any strong opinions against doing this? If not, I'll try to get this landed tomorrow ...
5 years ago (2015-11-25 19:12:51 UTC) #2
fmalita_google_do_not_use
lgtm
5 years ago (2015-11-25 19:15:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476523002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476523002/80001
5 years ago (2015-11-26 12:45:51 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-11-26 12:52:13 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-26 12:53:04 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6472368bac3c0c37507635022896a9eecf2ed032
Cr-Commit-Position: refs/heads/master@{#361873}

Powered by Google App Engine
This is Rietveld 408576698