Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

Issue 1476503004: [page_load_metrics] User Initiated Abort Tracking (Observer version) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_observer
Patch Set: Only eagerly log on renderer crash Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
index 54060a08e3d996530899e655d8ea48b213bb19b9..026f0dd9683d5bdee48d477d165e5b89d5fda786 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
@@ -474,6 +474,25 @@ TEST_F(MetricsWebContentsObserverTest, AbortProvisionalLoad) {
CheckTotalEvents();
}
+TEST_F(MetricsWebContentsObserverTest, BackgroundBeforePaint) {
+ page_load_metrics::PageLoadTiming timing;
+ timing.navigation_start = base::Time::FromDoubleT(1);
+ timing.first_paint = base::TimeDelta::FromSeconds(10);
+ content::WebContentsTester* web_contents_tester =
+ content::WebContentsTester::For(web_contents());
+ web_contents_tester->NavigateAndCommit(GURL("https://www.google.com"));
+ // Background the tab and go for a coffee or something.
+ observer_->WasHidden();
+ observer_->OnMessageReceived(
+ PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
+ main_rfh());
+ // Come back and start browsing again.
+ observer_->WasShown();
+ // Simulate the user performaning another navigation.
+ web_contents_tester->NavigateAndCommit(GURL("https://www.example.com"));
+ histogram_tester_.ExpectTotalCount(kHistogramBackgroundBeforePaint, 1);
+}
+
TEST_F(MetricsWebContentsObserverTest, AbortProvisionalLoadInBackground) {
content::WebContentsTester* web_contents_tester =
content::WebContentsTester::For(web_contents());

Powered by Google App Engine
This is Rietveld 408576698