[page_load_metrics] User Initiated Abort Tracking (Observer version)

chrome/browser/page_load_metrics/observers/page_load_metrics_observers_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/test/histogram_tester.h"
+#include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h"
 #include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "components/page_load_metrics/browser/metrics_web_contents_observer.h"
 #include "components/page_load_metrics/common/page_load_metrics_messages.h"
 #include "content/public/test/web_contents_tester.h"
 #include "url/gurl.h"
 
 namespace {
 
@@ skipping 25 matching lines @@
   TestPageLoadMetricsEmbedderInterface()
       : referrer_(content::Referrer(GURL("https://www.google.com"),
                                     blink::WebReferrerPolicyDefault)) {}
   rappor::RapporService* GetRapporService() override { return nullptr; }
   bool IsPrerendering(content::WebContents* web_contents) override {
     return false;
   }
   void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override {
     tracker->AddObserver(
         make_scoped_ptr(new TestFromGWSPageLoadMetricsObserver(referrer_)));
+    tracker->AddObserver(

[Bryan McQuade, 2015/12/10 17:04:23]

I'd like to have a separate aborts_page_load_metrics_observer_unittest.cc for
this, perhaps with a common base test class that supports testing of observers.
I don't want us to put each observer's tests in a single file. We can fix this
in a follow up CL though. Can you add a TODO for it and/or file a bug? Let's try
to fix it soon so subsequent observers can easily add their own unittest.cc
files.

[Charlie Harrison, 2015/12/10 17:59:31]

I have a bug filed for this. I'll do it asap after this change lands.

+        make_scoped_ptr(new AbortsPageLoadMetricsObserver()));
   }
   void set_referrer(const content::Referrer& referrer) { referrer_ = referrer; }
 
  private:
   content::Referrer referrer_;
 
   DISALLOW_COPY_AND_ASSIGN(TestPageLoadMetricsEmbedderInterface);
 };
 
 class PageLoadMetricsObserverTest : public ChromeRenderViewHostTestHarness {
@@ skipping 168 matching lines @@
 
   observer_->OnMessageReceived(
       PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
       web_contents()->GetMainFrame());
 
   // Navigate again to force logging.
   NavigateAndCommit(GURL("https://www.google.com"));
   histogram_tester_.ExpectTotalCount(kHistogramNameFromGWSFirstTextPaint, 0);
 }
 
+TEST_F(PageLoadMetricsObserverTest, AbortStopClose) {
+  page_load_metrics::PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  content::WebContentsTester* web_contents_tester =
+      content::WebContentsTester::For(web_contents());
+  NavigateAndCommit(GURL("https://www.google.com"));
+  observer_->OnMessageReceived(
+      PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
+      web_contents()->GetMainFrame());
+  // Simulate the user pressing the stop button.
+  observer_->NavigationStopped();
+  web_contents_tester->NavigateAndCommit(GURL("https://www.example.com"));
+  observer_->OnMessageReceived(
+      PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
+      web_contents()->GetMainFrame());
+  // Kill the MetricsWebContentsObserver to simulate closing the tab.
+  observer_.reset();
+  histogram_tester_.ExpectTotalCount(kHistogramAbortStopBeforePaint, 1);
+  histogram_tester_.ExpectTotalCount(kHistogramAbortCloseBeforePaint, 1);
+}
+
+TEST_F(PageLoadMetricsObserverTest, AbortNewNavigation) {
+  page_load_metrics::PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  content::WebContentsTester* web_contents_tester =
+      content::WebContentsTester::For(web_contents());
+  web_contents_tester->NavigateAndCommit(GURL("https://www.google.com"));
+  observer_->OnMessageReceived(
+      PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
+      web_contents()->GetMainFrame());
+  // Simulate the user performaning another navigation before first paint.
+  web_contents_tester->NavigateAndCommit(GURL("https://www.example.com"));
+  histogram_tester_.ExpectTotalCount(kHistogramAbortNewNavigationBeforePaint,
+                                     1);
+}
+
+TEST_F(PageLoadMetricsObserverTest, NoAbortNewNavigationFromAboutURL) {
+  content::WebContentsTester* web_contents_tester =
+      content::WebContentsTester::For(web_contents());
+  web_contents_tester->NavigateAndCommit(GURL("about:blank"));
+  web_contents_tester->NavigateAndCommit(GURL("https://www.example.com"));
+  histogram_tester_.ExpectTotalCount(kHistogramAbortNewNavigationBeforePaint,
+                                     0);
+}
+
+TEST_F(PageLoadMetricsObserverTest, NoAbortNewNavigationAfterPaint) {
+  page_load_metrics::PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  timing.first_paint = base::TimeDelta::FromMicroseconds(1);
+  content::WebContentsTester* web_contents_tester =
+      content::WebContentsTester::For(web_contents());
+  web_contents_tester->NavigateAndCommit(GURL("https://www.google.com"));
+  observer_->OnMessageReceived(
+      PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing),
+      web_contents()->GetMainFrame());
+  web_contents_tester->NavigateAndCommit(GURL("https://www.example.com"));
+  histogram_tester_.ExpectTotalCount(kHistogramAbortNewNavigationBeforePaint,
+                                     0);
+}
+
+
 TEST_F(PageLoadMetricsObserverTest, IsGoogleCaptcha) {
   struct {
     std::string url;
     bool expected;
   } test_cases[] = {
       {"", false},
       {"http://www.google.com/", false},
       {"http://www.cnn.com/", false},
       {"http://ipv4.google.com/", false},
       {"https://ipv4.google.com/sorry/IndexRedirect?continue=http://a", true},
       {"https://ipv6.google.com/sorry/IndexRedirect?continue=http://a", true},
       {"https://ipv7.google.com/sorry/IndexRedirect?continue=http://a", false},
   };
   for (const auto& test : test_cases) {
     EXPECT_EQ(test.expected,
               google_captcha_observer::IsGoogleCaptcha(GURL(test.url)))
         << "for URL: " << test.url;
   }
 }