Issue 14765016: Revert 198491 "Render opaque border with no shadow for web conte..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14765016: Revert 198491 "Render opaque border with no shadow for web conte..." (Closed)

Created:
7 years, 7 months ago by tommi1

Modified:
7 years, 7 months ago

Reviewers:
Mike Wittman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 198491 "Render opaque border with no shadow for web conte..." Broke the chromiumos bots: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/9294/steps/cbuildbot/logs/stdio > Render opaque border with no shadow for web contents modal dialogs under Views/Win32 > > This is a temporary kludge to get web contents modal dialog frames > displaying acceptably under Views/Win32. It's not possible to use > transparency in the frames on Win7 and earlier OSes unless the web > contents modal dialogs are top-level windows, which is undesirable. > Making web contents modal dialogs top-level imposes additional > complexities and burdens on managing focus, activation, and window > position relative to the browser window, soley for the View/Win32 case. > It's best to avoid this since we won't need it once we transition > to Aura. > > See screenshots at http://crbug.com/231012#c6. > > > BUG=231012, 166075 > > Review URL: https://chromiumcodereview.appspot.com/14742002 TBR=wittman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198506

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -87 lines)			Patch
M	trunk/src/chrome/browser/ui/views/constrained_window_views.cc	View	3 chunks	+2 lines, -19 lines	0 comments	Download
M	trunk/src/ui/views/bubble/bubble_border.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/ui/views/bubble/bubble_border.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/ui/views/bubble/bubble_frame_view.cc	View	2 chunks	+1 line, -37 lines	0 comments	Download
M	trunk/src/ui/views/window/dialog_delegate.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	trunk/src/ui/views/window/dialog_delegate.cc	View	2 chunks	+2 lines, -18 lines	0 comments	Download

Total messages: 3 (0 generated)

Mike Wittman

7 years, 7 months ago (2013-05-06 19:52:38 UTC) #3

Message was sent while issue was closed.

On 2013/05/06 19:30:18, tommi1 wrote:
> Committed patchset #1 manually as r198506.

lgtm