Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3450)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

Issue 1476463002: Disable ManagePasswordsBubbleViewTest.CloseOnClick on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
index 81170e071f53408617b206ce1ad07131f1747daf..7f4401f1ada3e204ba5be1a703be8f037a4442db 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc
@@ -217,8 +217,13 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest,
metrics_util::MANUAL_MANAGE_PASSWORDS));
}
-// If this flakes, disable and log details in http://crbug.com/523255.
-IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, CloseOnClick) {
+// Flaky on Windows (http://crbug.com/523255).
+#if defined(OS_WIN)
+#define MAYBE_CloseOnClick DISABLED_CloseOnClick
+#else
+#define MAYBE_CloseOnClick CloseOnClick
+#endif
+IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, MAYBE_CloseOnClick) {
SetupPendingPassword();
EXPECT_TRUE(IsBubbleShowing());
EXPECT_FALSE(ManagePasswordsBubbleView::manage_password_bubble()->
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698