Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: src/code-stubs.h

Issue 1476413003: Provide call counts for constructor calls, surface them as a vector IC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.cc ('k') | src/compiler/js-call-reducer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 8bf470115d1d79b4d1fadac2a5c3eff39ad7551a..fb22e49213542778547858b0acc50a64be0a43dc 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -26,8 +26,8 @@ namespace internal {
V(CallApiFunction) \
V(CallApiAccessor) \
V(CallApiGetter) \
- V(CallConstruct) \
V(CallIC) \
+ V(ConstructIC) \
V(CEntry) \
V(CompareIC) \
V(DoubleToI) \
@@ -1962,13 +1962,16 @@ class RegExpConstructResultStub final : public HydrogenCodeStub {
};
-// TODO(bmeurer/mvstanton): Turn CallConstructStub into ConstructICStub.
-class CallConstructStub final : public PlatformCodeStub {
+class ConstructICStub final : public PlatformCodeStub {
public:
- explicit CallConstructStub(Isolate* isolate) : PlatformCodeStub(isolate) {}
+ explicit ConstructICStub(Isolate* isolate) : PlatformCodeStub(isolate) {}
- DEFINE_CALL_INTERFACE_DESCRIPTOR(CallConstruct);
- DEFINE_PLATFORM_CODE_STUB(CallConstruct, PlatformCodeStub);
+ Code::Kind GetCodeKind() const override { return Code::CONSTRUCT_IC; }
+
+ InlineCacheState GetICState() const final { return GENERIC; }
+
+ DEFINE_CALL_INTERFACE_DESCRIPTOR(Construct);
+ DEFINE_PLATFORM_CODE_STUB(ConstructIC, PlatformCodeStub);
};
« no previous file with comments | « src/code-factory.cc ('k') | src/compiler/js-call-reducer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698