Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: src/compiler/js-inlining-heuristic.cc

Issue 1476413003: Provide call counts for constructor calls, surface them as a vector IC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-call-reducer.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-inlining-heuristic.h" 5 #include "src/compiler/js-inlining-heuristic.h"
6 6
7 #include "src/compiler.h" 7 #include "src/compiler.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/objects-inl.h" 9 #include "src/objects-inl.h"
10 10
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 // Stop inlinining once the maximum allowed level is reached. 68 // Stop inlinining once the maximum allowed level is reached.
69 int level = 0; 69 int level = 0;
70 for (Node* frame_state = NodeProperties::GetFrameStateInput(node, 0); 70 for (Node* frame_state = NodeProperties::GetFrameStateInput(node, 0);
71 frame_state->opcode() == IrOpcode::kFrameState; 71 frame_state->opcode() == IrOpcode::kFrameState;
72 frame_state = NodeProperties::GetFrameStateInput(frame_state, 0)) { 72 frame_state = NodeProperties::GetFrameStateInput(frame_state, 0)) {
73 if (++level > FLAG_max_inlining_levels) return NoChange(); 73 if (++level > FLAG_max_inlining_levels) return NoChange();
74 } 74 }
75 75
76 // Gather feedback on how often this call site has been hit before. 76 // Gather feedback on how often this call site has been hit before.
77 int calls = -1; // Same default as CallICNexus::ExtractCallCount. 77 int calls = -1; // Same default as CallICNexus::ExtractCallCount.
78 // TODO(turbofan): We also want call counts for constructor calls.
79 if (node->opcode() == IrOpcode::kJSCallFunction) { 78 if (node->opcode() == IrOpcode::kJSCallFunction) {
80 CallFunctionParameters p = CallFunctionParametersOf(node->op()); 79 CallFunctionParameters p = CallFunctionParametersOf(node->op());
81 if (p.feedback().IsValid()) { 80 if (p.feedback().IsValid()) {
82 CallICNexus nexus(p.feedback().vector(), p.feedback().slot()); 81 CallICNexus nexus(p.feedback().vector(), p.feedback().slot());
83 calls = nexus.ExtractCallCount(); 82 calls = nexus.ExtractCallCount();
84 } 83 }
84 } else if (node->opcode() == IrOpcode::kJSCallConstruct) {
85 CallConstructParameters p = CallConstructParametersOf(node->op());
86 if (p.feedback().IsValid()) {
87 ConstructICNexus nexus(p.feedback().vector(), p.feedback().slot());
88 calls = nexus.ExtractCallCount();
89 }
85 } 90 }
86 91
87 // --------------------------------------------------------------------------- 92 // ---------------------------------------------------------------------------
88 // Everything above this line is part of the inlining heuristic. 93 // Everything above this line is part of the inlining heuristic.
89 // --------------------------------------------------------------------------- 94 // ---------------------------------------------------------------------------
90 95
91 // In the general case we remember the candidate for later. 96 // In the general case we remember the candidate for later.
92 candidates_.insert({function, node, calls}); 97 candidates_.insert({function, node, calls});
93 return NoChange(); 98 return NoChange();
94 } 99 }
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 candidate.node->id(), candidate.calls, 134 candidate.node->id(), candidate.calls,
130 candidate.function->shared()->SourceSize(), 135 candidate.function->shared()->SourceSize(),
131 candidate.function->shared()->ast_node_count(), 136 candidate.function->shared()->ast_node_count(),
132 candidate.function->shared()->DebugName()->ToCString().get()); 137 candidate.function->shared()->DebugName()->ToCString().get());
133 } 138 }
134 } 139 }
135 140
136 } // namespace compiler 141 } // namespace compiler
137 } // namespace internal 142 } // namespace internal
138 } // namespace v8 143 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-call-reducer.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698