Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1476413003: Provide call counts for constructor calls, surface them as a vector IC. (Closed)

Created:
5 years ago by mvstanton
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Provide call counts for constructor calls, surface them as a vector IC. CallIC and CallConstructStub look so alike, at least in the feedback they gather even if the implementation differs...and CallIC has such a nice way of surfacing the feedback (CallICNexus), that there is a request to make CallConstructStub look analogous. Enter ConstructICStub. BUG= Committed: https://crrev.com/66d5a9df62da458a51e8c7ed1811dc9660f4f418 Cr-Commit-Position: refs/heads/master@{#32452}

Patch Set 1 #

Patch Set 2 : Refactoring. #

Patch Set 3 : Ports. #

Patch Set 4 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -185 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 5 chunks +18 lines, -3 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 5 chunks +23 lines, -3 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/ast/ast.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/code-factory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 1 2 3 4 chunks +52 lines, -60 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 5 chunks +17 lines, -3 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/ic.h View 1 2 chunks +13 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/log.h View 1 chunk +56 lines, -56 lines 0 comments Download
M src/log.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 5 chunks +20 lines, -3 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 5 chunks +21 lines, -3 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/objects-printer.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M src/type-feedback-vector.h View 1 6 chunks +23 lines, -4 lines 0 comments Download
M src/type-feedback-vector.cc View 1 4 chunks +24 lines, -0 lines 0 comments Download
M src/type-info.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 6 chunks +14 lines, -3 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
mvstanton
Hi Benedikt, here is ConstructIC. Thanks for the look! --Mike
5 years ago (2015-11-30 15:48:57 UTC) #3
Benedikt Meurer
LGTM.
5 years ago (2015-12-01 10:03:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476413003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476413003/60001
5 years ago (2015-12-01 10:44:35 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-01 11:06:15 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/66d5a9df62da458a51e8c7ed1811dc9660f4f418 Cr-Commit-Position: refs/heads/master@{#32452}
5 years ago (2015-12-01 11:06:46 UTC) #10
Benedikt Meurer
5 years ago (2015-12-04 07:33:19 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1489413006/ by bmeurer@chromium.org.

The reason for reverting is: Seems to be (mostly) responsible for the most
recent Speedometer regression, not 100% sure. Let's see what the bots have to
say..

Powered by Google App Engine
This is Rietveld 408576698