Don't intrusively mark in the heap snapshot generator

Don't intrusively mark in the heap snapshot generator

BUG=

Committed: https://crrev.com/1779136f5d29b90fb7001fa4ee56b84b7efc9291
Cr-Commit-Position: refs/heads/master@{#32369}

[Toon Verwaest, 2015-11-27 10:08:07]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org

[Toon Verwaest, 2015-11-27 10:08:08]

ptal

[Igor Sheludko, 2015-11-27 10:16:39]

lgtm with nits:

https://codereview.chromium.org/1476413002/diff/1/src/profiler/heap-snapshot-...
File src/profiler/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/1476413002/diff/1/src/profiler/heap-snapshot-...
src/profiler/heap-snapshot-generator.cc:1008: if (p >=
HeapObject::RawField(parent_obj_, 0) && p < real_end_ &&
I think it would be cleaner to have both object_start_ and object_end_ fields.

And please add a comment why do we need the range checking.

[Toon Verwaest, 2015-11-27 10:21:21]

Addressed comments

[Toon Verwaest, 2015-11-27 10:21:26]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-11-27 10:21:27]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1476413002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2015-11-27 10:21:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476413002/20001

[commit-bot: I haz the power, 2015-11-27 10:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-27 10:27:46]

Try jobs failed on following builders:
  v8_win_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/12345)

[Toon Verwaest, 2015-11-27 11:00:35]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-11-27 11:00:35]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1476413002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-11-27 11:00:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476413002/40001

[commit-bot: I haz the power, 2015-11-27 12:05:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-27 12:06:01]

Description was changed from

==========
Don't intrusively mark in the heap snapshot generator

BUG=
==========

to

==========
Don't intrusively mark in the heap snapshot generator

BUG=

Committed: https://crrev.com/1779136f5d29b90fb7001fa4ee56b84b7efc9291
Cr-Commit-Position: refs/heads/master@{#32369}
==========

[commit-bot: I haz the power, 2015-11-27 12:06:02]

Patchset 3 (id:??) landed as
https://crrev.com/1779136f5d29b90fb7001fa4ee56b84b7efc9291
Cr-Commit-Position: refs/heads/master@{#32369}