Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1476403004: Remove Object::IsSpecObject, use Object::IsJSReceiver instead. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove Object::IsSpecObject, use Object::IsJSReceiver instead. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/0c7bc1cd5fa133f7339ef84b66837a9aa24a02bb Cr-Commit-Position: refs/heads/master@{#32398}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/contexts.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 7 chunks +8 lines, -8 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +1 line, -7 lines 0 comments Download
M src/property-descriptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-proxy.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
neis
5 years ago (2015-11-27 17:07:02 UTC) #1
Jakob Kummerow
This is probably fine as a first step, but note that it only addresses 17 ...
5 years ago (2015-11-28 10:51:09 UTC) #3
Benedikt Meurer
LGTM
5 years ago (2015-11-30 09:19:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476403004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476403004/20001
5 years ago (2015-11-30 10:30:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-30 10:51:37 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-30 10:52:19 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c7bc1cd5fa133f7339ef84b66837a9aa24a02bb
Cr-Commit-Position: refs/heads/master@{#32398}

Powered by Google App Engine
This is Rietveld 408576698