Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2478)

Unified Diff: base/android/java_handler_thread.h

Issue 1476403003: jni: Pass method parameters as JavaParamRef in base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/android/java_handler_thread.cc » ('j') | base/android/jni_generator/sample_for_tests.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java_handler_thread.h
diff --git a/base/android/java_handler_thread.h b/base/android/java_handler_thread.h
index c9a2c02d3546ed3ffb557061db65f06bc487cd8f..bcd40335f7f6f79fe8731152a1683131cb5bb085 100644
--- a/base/android/java_handler_thread.h
+++ b/base/android/java_handler_thread.h
@@ -33,8 +33,12 @@ class BASE_EXPORT JavaHandlerThread {
// Called from java on the newly created thread.
// Start() will not return before this methods has finished.
- void InitializeThread(JNIEnv* env, jobject obj, jlong event);
- void StopThread(JNIEnv* env, jobject obj, jlong event);
+ void InitializeThread(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
nyquist 2015/12/02 01:35:42 We're already in base::android namespace. Is names
+ jlong event);
+ void StopThread(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jlong event);
static bool RegisterBindings(JNIEnv* env);
« no previous file with comments | « no previous file | base/android/java_handler_thread.cc » ('j') | base/android/jni_generator/sample_for_tests.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698