Issue 1476303003: dart2js cps: Disable a bad optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1476303003: dart2js cps: Disable a bad optimization. (Closed)

Created:
5 years ago by asgerf

Modified:
5 years ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Disable a bad optimization. An optimization would remove redundant == null checks from branch conditions, but this slows the check. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/e2a1b39037f995c4709536d393603e70de478fbc

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -38 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	1	1 chunk	+0 lines, -38 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

5 years ago (2015-11-30 10:30:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e2a1b39037f995c4709536d393603e70de478fbc (presubmit successful).