Drop PathParsingMode argument to buildStringFromByteStream

Drop PathParsingMode argument to buildStringFromByteStream

Just always produce a String with whatever format the input is.

Also cleanup some related code, and expose SVGPath from SVGPathElement
rather than the SVGPathByteStream.

BUG=467592
Committed: https://crrev.com/a3b40f563264af73bdf90cfc8adb0bc0410fb221
Cr-Commit-Position: refs/heads/master@{#361988}

[fs, 2015-11-26 15:32:55]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org

[fs, 2015-11-27 09:37:34]

fs@opera.com changed reviewers:
+ davve@opera.com

[fs, 2015-11-27 09:37:35]

davve, PTAL

[davve, 2015-11-27 09:45:58]

Non-owner LGTM

https://codereview.chromium.org/1476283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGPath.cpp (right):

https://codereview.chromium.org/1476283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGPath.cpp:125: return
buildStringFromByteStream(byteStream());
Does this mean you may drop #include "core/svg/SVGPathParser.h"?

https://codereview.chromium.org/1476283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGPath.h (left):

https://codereview.chromium.org/1476283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGPath.h:40: class SVGPathByteStream;
nit: may drop forward declaration.

[philipj_slow, 2015-11-27 10:03:53]

philipj@opera.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2015-11-27 10:03:53]

rs lgtm

[fs, 2015-11-27 11:38:53]

https://codereview.chromium.org/1476283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGPath.cpp (right):

https://codereview.chromium.org/1476283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGPath.cpp:125: return
buildStringFromByteStream(byteStream());
On 2015/11/27 at 09:45:57, David Vest wrote:
> Does this mean you may drop #include "core/svg/SVGPathParser.h"?

Yepp. Done.

https://codereview.chromium.org/1476283002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGPath.h (left):

https://codereview.chromium.org/1476283002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGPath.h:40: class SVGPathByteStream;
On 2015/11/27 at 09:45:58, David Vest wrote:
> nit: may drop forward declaration.

Done.

[fs, 2015-11-27 12:22:41]

The CQ bit was checked by fs@opera.com

[fs, 2015-11-27 12:22:41]

The patchset sent to the CQ was uploaded after l-g-t-m from davve@opera.com,
philipj@opera.com
Link to the patchset: https://codereview.chromium.org/1476283002/#ps20001
(title: "Remove include; Drop forward decl.")

[commit-bot: I haz the power, 2015-11-27 12:23:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476283002/20001

[commit-bot: I haz the power, 2015-11-27 12:59:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-27 13:00:38]

Description was changed from

==========
Drop PathParsingMode argument to buildStringFromByteStream

Just always produce a String with whatever format the input is.

Also cleanup some related code, and expose SVGPath from SVGPathElement
rather than the SVGPathByteStream.

BUG=467592
==========

to

==========
Drop PathParsingMode argument to buildStringFromByteStream

Just always produce a String with whatever format the input is.

Also cleanup some related code, and expose SVGPath from SVGPathElement
rather than the SVGPathByteStream.

BUG=467592

Committed: https://crrev.com/a3b40f563264af73bdf90cfc8adb0bc0410fb221
Cr-Commit-Position: refs/heads/master@{#361988}
==========

[commit-bot: I haz the power, 2015-11-27 13:00:39]

Patchset 2 (id:??) landed as
https://crrev.com/a3b40f563264af73bdf90cfc8adb0bc0410fb221
Cr-Commit-Position: refs/heads/master@{#361988}