Remove ScopedVector from IDStores

Remove ScopedVector from DefaultChannelIDStore,  SQLiteChannelIDStore and QuotaPolicyChannelIDStore.

BUG=554289
Committed: https://crrev.com/44642944b0d6d6b799d09a834bf241ee9b1b0015
Cr-Commit-Position: refs/heads/master@{#362657}

[Olli Raula, 2015-11-30 09:19:29]

Description was changed from

==========
Remove ScopedVector from DefaultChannelIDStore and friends

BUG=554289
==========

to

==========
Remove ScopedVector from DefaultChannelIDStore,  SQLiteChannelIDStore and
QuotaPolicyChannelIDStore.

BUG=554289
==========

[Olli Raula, 2015-11-30 09:29:49]

olli.raula@intel.com changed reviewers:
+ mmenke@chromium.org

[Olli Raula, 2015-11-30 09:30:27]

COuld you review?

[mmenke, 2015-11-30 20:33:17]

Just minor comments.

https://codereview.chromium.org/1476263004/diff/1/chrome/browser/net/quota_po...
File chrome/browser/net/quota_policy_channel_id_store.h (right):

https://codereview.chromium.org/1476263004/diff/1/chrome/browser/net/quota_po...
chrome/browser/net/quota_policy_channel_id_store.h:54: ChannelIDVector;
include <vector>

https://codereview.chromium.org/1476263004/diff/1/chrome/browser/net/quota_po...
File chrome/browser/net/quota_policy_channel_id_store_unittest.cc (right):

https://codereview.chromium.org/1476263004/diff/1/chrome/browser/net/quota_po...
chrome/browser/net/quota_policy_channel_id_store_unittest.cc:32: void
Load(std::vector<scoped_ptr<net::DefaultChannelIDStore::ChannelID>>*
include <vector>

https://codereview.chromium.org/1476263004/diff/1/chrome/browser/net/quota_po...
chrome/browser/net/quota_policy_channel_id_store_unittest.cc:104: foo_channel_id
= std::move(channel_ids[1]);
Any reason for passing ownership here?  Doesn't seem like it gets us much.

https://codereview.chromium.org/1476263004/diff/1/chrome/browser/net/quota_po...
chrome/browser/net/quota_policy_channel_id_store_unittest.cc:116: //  Now delete
the channel ID and check persistence again.
Remove extra space.

https://codereview.chromium.org/1476263004/diff/1/net/extras/sqlite/sqlite_ch...
File net/extras/sqlite/sqlite_channel_id_store.cc (right):

https://codereview.chromium.org/1476263004/diff/1/net/extras/sqlite/sqlite_ch...
net/extras/sqlite/sqlite_channel_id_store.cc:84:
std::vector<scoped_ptr<DefaultChannelIDStore::ChannelID>>* channel_ids);
include vector

https://codereview.chromium.org/1476263004/diff/1/net/extras/sqlite/sqlite_ch...
File net/extras/sqlite/sqlite_channel_id_store_unittest.cc (right):

https://codereview.chromium.org/1476263004/diff/1/net/extras/sqlite/sqlite_ch...
net/extras/sqlite/sqlite_channel_id_store_unittest.cc:30:
std::vector<scoped_ptr<DefaultChannelIDStore::ChannelID>>* channel_ids) {
include vector, scoped_ptr

https://codereview.chromium.org/1476263004/diff/1/net/extras/sqlite/sqlite_ch...
net/extras/sqlite/sqlite_channel_id_store_unittest.cc:149: foo_channel_id =
std::move(channel_ids[0]);
Again, not sure this really gets us much.

[Olli Raula, 2015-12-01 12:39:24]

Thanks, fixed

[mmenke, 2015-12-01 15:44:54]

On 2015/12/01 12:39:24, Olli Raula wrote:
> Thanks, fixed

LGTM!

[Olli Raula, 2015-12-02 07:36:09]

The CQ bit was checked by olli.raula@intel.com

[commit-bot: I haz the power, 2015-12-02 07:36:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476263004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476263004/20001

[commit-bot: I haz the power, 2015-12-02 07:40:16]

Description was changed from

==========
Remove ScopedVector from DefaultChannelIDStore,  SQLiteChannelIDStore and
QuotaPolicyChannelIDStore.

BUG=554289
==========

to

==========
Remove ScopedVector from DefaultChannelIDStore,  SQLiteChannelIDStore and
QuotaPolicyChannelIDStore.

BUG=554289
==========

[commit-bot: I haz the power, 2015-12-02 07:40:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-02 07:40:57]

Description was changed from

==========
Remove ScopedVector from DefaultChannelIDStore,  SQLiteChannelIDStore and
QuotaPolicyChannelIDStore.

BUG=554289
==========

to

==========
Remove ScopedVector from DefaultChannelIDStore,  SQLiteChannelIDStore and
QuotaPolicyChannelIDStore.

BUG=554289

Committed: https://crrev.com/44642944b0d6d6b799d09a834bf241ee9b1b0015
Cr-Commit-Position: refs/heads/master@{#362657}
==========

[commit-bot: I haz the power, 2015-12-02 07:40:57]

Patchset 2 (id:??) landed as
https://crrev.com/44642944b0d6d6b799d09a834bf241ee9b1b0015
Cr-Commit-Position: refs/heads/master@{#362657}