Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Side by Side Diff: chrome/browser/ui/views/tabs/tab.h

Issue 147623004: Tab close buttons can only be targeted with touch if the whole button is visible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments addressed Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_
6 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_ 6 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 10
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 117
118 // Returns the height for immersive mode tabs. 118 // Returns the height for immersive mode tabs.
119 static int GetImmersiveHeight(); 119 static int GetImmersiveHeight();
120 120
121 private: 121 private:
122 friend class TabTest; 122 friend class TabTest;
123 FRIEND_TEST_ALL_PREFIXES(TabTest, CloseButtonLayout); 123 FRIEND_TEST_ALL_PREFIXES(TabTest, CloseButtonLayout);
124 124
125 friend class TabStripTest; 125 friend class TabStripTest;
126 FRIEND_TEST_ALL_PREFIXES(TabStripTest, TabHitTestMaskWhenStacked); 126 FRIEND_TEST_ALL_PREFIXES(TabStripTest, TabHitTestMaskWhenStacked);
127 FRIEND_TEST_ALL_PREFIXES(TabStripTest, ClippedTabCloseButton);
127 128
128 // The animation object used to swap the favicon with the sad tab icon. 129 // The animation object used to swap the favicon with the sad tab icon.
129 class FaviconCrashAnimation; 130 class FaviconCrashAnimation;
130 class TabCloseButton; 131 class TabCloseButton;
131 132
132 // Contains a cached image and the values used to generate it. 133 // Contains a cached image and the values used to generate it.
133 struct ImageCacheEntry { 134 struct ImageCacheEntry {
134 ImageCacheEntry(); 135 ImageCacheEntry();
135 ~ImageCacheEntry(); 136 ~ImageCacheEntry();
136 137
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 static int font_height_; 369 static int font_height_;
369 370
370 // As the majority of the tabs are inactive, and painting tabs is slowish, 371 // As the majority of the tabs are inactive, and painting tabs is slowish,
371 // we cache a handful of the inactive tab backgrounds here. 372 // we cache a handful of the inactive tab backgrounds here.
372 static ImageCache* image_cache_; 373 static ImageCache* image_cache_;
373 374
374 DISALLOW_COPY_AND_ASSIGN(Tab); 375 DISALLOW_COPY_AND_ASSIGN(Tab);
375 }; 376 };
376 377
377 #endif // CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_ 378 #endif // CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698