Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1476223002: [heap] Remove eager shortcut in JSFunction visitor. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove eager shortcut in JSFunction visitor. This removes an optimization in the static JSFunction visitor that eagerly marked through to the SharedFunctionInfo for code flushing candidates. This causes all processing in VisitJSFunction to be side-stepped and hence might cause leaks. R=hpayer@chromium.org Committed: https://crrev.com/a29f0576c32e8fda90bf7ab19c6d170568150a7f Cr-Commit-Position: refs/heads/master@{#32332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/heap/objects-visiting-inl.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years ago (2015-11-26 09:27:24 UTC) #1
Hannes Payer (out of office)
lgtm
5 years ago (2015-11-26 09:53:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476223002/1
5 years ago (2015-11-26 11:34:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 11:36:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a29f0576c32e8fda90bf7ab19c6d170568150a7f Cr-Commit-Position: refs/heads/master@{#32332}
5 years ago (2015-11-26 11:36:39 UTC) #7
Hannes Payer (out of office)
5 years ago (2015-12-01 13:30:30 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1488063002/ by hpayer@chromium.org.

The reason for reverting is: Still investigating bad canary..

Powered by Google App Engine
This is Rietveld 408576698