Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: components/crash.gypi

Issue 1476193002: Revert of Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/interactive_ui_tests.isolate ('k') | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/crash/core/browser 8 # GN version: //components/crash/core/browser
9 'target_name': 'crash_core_browser', 9 'target_name': 'crash_core_browser',
10 'type': 'static_library', 10 'type': 'static_library',
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 'include_dirs': [ 87 'include_dirs': [
88 '..', 88 '..',
89 '../breakpad/src', 89 '../breakpad/src',
90 ], 90 ],
91 }, 91 },
92 { 92 {
93 # TODO(mark): https://crbug.com/466890: merge this target with 93 # TODO(mark): https://crbug.com/466890: merge this target with
94 # crash_component. 94 # crash_component.
95 # 95 #
96 # This is a temporary base target that is depended on by both 96 # This is a temporary base target that is depended on by both
97 # crash_component and crash_component_breakpad_to_be_deleted. It 97 # crash_component and crash_component_breakpad_mac_to_be_deleted. It
98 # provides everything common to both of those targets. For a short 98 # provides everything common to both of those targets. For a short per iod,
99 # period, there are two Mac and Windows crash component 99 # there are two Mac crash component implementations. The new one uses a
100 # implementations. The new one uses a Crashpad implementation and is 100 # Crashpad implementation and is used by Chrome. The old one uses a
101 # used by Chrome. The old one uses a Breakpad implementation and is 101 # Breakpad implementation and is used by content_shell. Consumers shou ld
102 # used by content_shell. Consumers should depend on the desired 102 # depend on the desired target. All three targets behave identically o n
103 # target. All three targets behave identically on non-Mac/-Windows. 103 # non-Mac. When content_shell and any other consumers are migrated to the
104 # When content_shell and any other consumers are migrated to the 104 # Crashpad implementation on Mac, crash_component will merge back into
105 # Crashpad implementation on Mac/Windows, crash_component will merge 105 # this target, crash_component_non_mac, which will be renamed
106 # back into this target, crash_component_non_mac_win, which will be 106 # crash_component. crash_component_breakpad_mac_to_be_deleted will be
107 # renamed crash_component. crash_component_breakpad_to_be_deleted will 107 # deleted.
108 # be deleted.
109 # 108 #
110 # While this situation exists: 109 # While this situation exists:
111 # 110 #
112 # Do not depend on this target directly! Depend on 111 # Do not depend on this target directly! Depend on
113 # crash_component_breakpad_to_be_deleted for old Breakpad behavior on 112 # crash_component_breakpad_mac_to_be_deleted for old Breakpad behavior on
114 # all platforms, or preferably, depend on crash_component to get Break pad 113 # all platforms, or preferably, depend on crash_component to get Break pad
115 # everywhere except for Mac and Windows, where you will get Crashpad. 114 # everywhere except for Mac, where you will get Crashpad.
116 # 115 #
117 # GN version: //components/crash/content/app:app_non_mac 116 # GN version: //components/crash/content/app:app_non_mac
118 'target_name': 'crash_component_non_mac_win', 117 'target_name': 'crash_component_non_mac',
119 'variables': { 118 'variables': {
120 'conditions': [ 119 'conditions': [
121 ['OS == "ios" or OS == "mac"', { 120 ['OS == "ios" or OS == "mac"', {
122 # On IOS there are no files compiled into the library, and we 121 # On IOS there are no files compiled into the library, and we
123 # can't have libraries with zero objects. 122 # can't have libraries with zero objects.
124 # For now, the same applies to Mac OS X, until this target 123 # For now, the same applies to Mac OS X, until this target merge s
125 # merges with crash_component. 124 # with crash_component.
126 'crash_component_target_type%': 'none', 125 'crash_component_target_type%': 'none',
127 }, { 126 }, {
128 'crash_component_target_type%': 'static_library', 127 'crash_component_target_type%': 'static_library',
129 }], 128 }],
130 ], 129 ],
131 }, 130 },
132 'type': '<(crash_component_target_type)', 131 'type': '<(crash_component_target_type)',
133 'sources': [ 132 'sources': [
134 'crash/content/app/breakpad_linux.cc', 133 'crash/content/app/breakpad_linux.cc',
135 'crash/content/app/breakpad_linux.h', 134 'crash/content/app/breakpad_linux.h',
136 'crash/content/app/breakpad_linux_impl.h', 135 'crash/content/app/breakpad_linux_impl.h',
136 'crash/content/app/breakpad_win.cc',
137 'crash/content/app/breakpad_win.h',
137 'crash/content/app/hard_error_handler_win.cc', 138 'crash/content/app/hard_error_handler_win.cc',
138 'crash/content/app/hard_error_handler_win.h', 139 'crash/content/app/hard_error_handler_win.h',
139 ], 140 ],
140 'dependencies': [ 141 'dependencies': [
141 'crash_component_lib', 142 'crash_component_lib',
142 '../base/base.gyp:base', 143 '../base/base.gyp:base',
143 ], 144 ],
144 'defines': ['CRASH_IMPLEMENTATION'], 145 'defines': ['CRASH_IMPLEMENTATION'],
145 'conditions': [ 146 'conditions': [
146 ['OS=="win"', { 147 ['OS=="win"', {
(...skipping 23 matching lines...) Expand all
170 ], 171 ],
171 }, 172 },
172 { 173 {
173 # Note: if you depend on this target, you need to either link in 174 # Note: if you depend on this target, you need to either link in
174 # content.gyp:content_common, or add 175 # content.gyp:content_common, or add
175 # content/public/common/content_switches.cc to your sources. 176 # content/public/common/content_switches.cc to your sources.
176 # 177 #
177 # GN version: //components/crash/content/app 178 # GN version: //components/crash/content/app
178 179
179 # TODO(mark): https://crbug.com/466890: merge this target with 180 # TODO(mark): https://crbug.com/466890: merge this target with
180 # crash_component_non_mac_win. 181 # crash_component_non_mac.
181 # 182 #
182 # Most of this target is actually in its dependency, 183 # Most of this target is actually in its dependency,
183 # crash_component_non_mac_win. See the comment in that target for an 184 # crash_component_non_mac. See the comment in that target for an
184 # explanation for the split. The split is temporary and the two target s 185 # explanation for the split. The split is temporary and the two target s
185 # will be unified again soon. 186 # will be unified again soon.
186 'target_name': 'crash_component', 187 'target_name': 'crash_component',
187 'variables': { 188 'variables': {
188 'conditions': [ 189 'conditions': [
189 ['OS != "mac" and OS != "win"', { 190 ['OS != "mac" ', {
190 # There are no source files except on Mac OS X and Windows. 191 # There are no source files on any platform but Mac OS X.
191 'crash_component_target_type%': 'none', 192 'crash_component_target_type%': 'none',
192 }, { 193 }, {
193 'crash_component_target_type%': 'static_library', 194 'crash_component_target_type%': 'static_library',
194 }], 195 }],
195 ], 196 ],
196 }, 197 },
197 'type': '<(crash_component_target_type)', 198 'type': '<(crash_component_target_type)',
198 'sources': [ 199 'sources': [
199 'crash/content/app/crashpad.cc', 200 'crash/content/app/crashpad_mac.h',
200 'crash/content/app/crashpad.h',
201 'crash/content/app/crashpad_mac.mm', 201 'crash/content/app/crashpad_mac.mm',
202 'crash/content/app/crashpad_win.cc',
203 ], 202 ],
204 'dependencies': [ 203 'dependencies': [
205 'crash_component_non_mac_win', 204 'crash_component_non_mac',
206 'crash_component_lib', 205 'crash_component_lib',
207 '../base/base.gyp:base', 206 '../base/base.gyp:base',
208 ], 207 ],
209 'defines': ['CRASH_IMPLEMENTATION'], 208 'defines': ['CRASH_IMPLEMENTATION'],
210 'conditions': [ 209 'conditions': [
211 ['OS=="mac" or OS=="win"', { 210 ['OS=="mac"', {
212 'dependencies': [ 211 'dependencies': [
213 '../third_party/crashpad/crashpad/client/client.gyp:crashpad_cli ent', 212 '../third_party/crashpad/crashpad/client/client.gyp:crashpad_cli ent',
214 ], 213 ],
215 }], 214 }],
216 ], 215 ],
217 }, 216 },
218 { 217 {
219 # TODO(mark): https://crbug.com/466890: remove this target. 218 # TODO(mark): https://crbug.com/466890: remove this target.
220 # 219 #
221 # This is a temporary target provided for Mac and Windows Breakpad 220 # This is a temporary target provided for Mac Breakpad users that have not
222 # users that have not yet migrated to Crashpad (namely content_shell). 221 # yet migrated to Crashpad (namely content_shell). This target will be
223 # This target will be removed shortly and all consumers will be 222 # removed shortly and all consumers will be expected to use Crashpad a s
224 # expected to use Crashpad as the Mac and Windows crash-reporting 223 # the Mac crash-reporting client. See the comment in the
225 # client. See the comment in the crash_component_non_mac_win target 224 # crash_component_non_mac target for more details.
226 # for more details.
227 # 225 #
228 # GN version: //components/crash/content/app:app_breakpad_mac_to_be_de leted 226 # GN version: //components/crash/content/app:app_breakpad_mac_to_be_de leted
229 'target_name': 'crash_component_breakpad_to_be_deleted', 227 'target_name': 'crash_component_breakpad_mac_to_be_deleted',
230 'variables': { 228 'variables': {
231 'conditions': [ 229 'conditions': [
232 ['OS != "mac" and OS != "win"', { 230 ['OS != "mac" ', {
233 # There are no source files on any platform but Mac OS X and 231 # There are no source files on any platform but Mac OS X.
234 # Windows.
235 'crash_component_target_type%': 'none', 232 'crash_component_target_type%': 'none',
236 }, { 233 }, {
237 'crash_component_target_type%': 'static_library', 234 'crash_component_target_type%': 'static_library',
238 }], 235 }],
239 ], 236 ],
240 }, 237 },
241 'type': '<(crash_component_target_type)', 238 'type': '<(crash_component_target_type)',
242 'sources': [ 239 'sources': [
243 'crash/content/app/breakpad_mac.h', 240 'crash/content/app/breakpad_mac.h',
244 'crash/content/app/breakpad_mac.mm', 241 'crash/content/app/breakpad_mac.mm',
245 'crash/content/app/breakpad_win.cc',
246 'crash/content/app/breakpad_win.h',
247 ], 242 ],
248 'dependencies': [ 243 'dependencies': [
249 'crash_component_non_mac_win', 244 'crash_component_non_mac',
250 'crash_component_lib', 245 'crash_component_lib',
251 ], 246 ],
252 'defines': ['CRASH_IMPLEMENTATION'], 247 'defines': ['CRASH_IMPLEMENTATION'],
253 'conditions': [ 248 'conditions': [
254 ['OS=="mac"', { 249 ['OS=="mac"', {
255 'dependencies': [ 250 'dependencies': [
256 '../breakpad/breakpad.gyp:breakpad', 251 '../breakpad/breakpad.gyp:breakpad',
257 ], 252 ],
258 'include_dirs': [ 253 'include_dirs': [
259 '..', 254 '..',
260 '../breakpad/src',
261 ],
262 }],
263 ['OS=="win"', {
264 'dependencies': [
265 '../breakpad/breakpad.gyp:breakpad_handler',
266 ],
267 'include_dirs': [
268 '..',
269 '../breakpad/src', 255 '../breakpad/src',
270 ], 256 ],
271 }], 257 }],
272 ], 258 ],
273 }, 259 },
274 { 260 {
275 # GN version: //components/crash/content/app:test_support 261 # GN version: //components/crash/content/app:test_support
276 'target_name': 'crash_test_support', 262 'target_name': 'crash_test_support',
277 'type': 'none', 263 'type': 'none',
278 'dependencies': [ 264 'dependencies': [
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 ], 398 ],
413 }], 399 }],
414 ], 400 ],
415 }, 401 },
416 ], 402 ],
417 }], 403 }],
418 ], 404 ],
419 }], 405 }],
420 ], 406 ],
421 } 407 }
OLDNEW
« no previous file with comments | « chrome/interactive_ui_tests.isolate ('k') | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698