Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1476173006: Use ContextUtils to get the app context in X509Util. (Closed)

Created:
5 years ago by Torne
Modified:
5 years ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContextUtils to get the app context in X509Util. Instead of implementing its own native call to get the application context, use the new Java-side application context in ContextUtils. This is exactly the same context object, set at exactly the same time in initialisation, just now available on both Java and native sides. BUG=525009 Committed: https://crrev.com/55efb96fce74ae1900670250cca36aee9964378a Cr-Commit-Position: refs/heads/master@{#362280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M net/android/java/src/org/chromium/net/X509Util.java View 3 chunks +2 lines, -6 lines 0 comments Download
M net/cert/x509_util_android.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Torne
5 years ago (2015-11-27 12:11:06 UTC) #2
davidben
lgtm
5 years ago (2015-11-30 18:53:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476173006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476173006/1
5 years ago (2015-11-30 22:06:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 23:54:25 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-30 23:55:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55efb96fce74ae1900670250cca36aee9964378a
Cr-Commit-Position: refs/heads/master@{#362280}

Powered by Google App Engine
This is Rietveld 408576698