Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1476153002: Drop [LegacyInterfaceTypeChecking] for APIs that are not enabled by default (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
Reviewers:
haraken
CC:
chromium-reviews, shans, rjwright, ajuma+watch-canvas_chromium.org, blink-reviews-animation_chromium.org, sof, eae+blinkwatch, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, dshwang, darktears, blink-reviews, rwlbuis, blink-reviews-html_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] for APIs that are not enabled by default These are all on interfaces or members that are [RuntimeEnabled=*] for a feature that is status=experimental or status=test. An existing contextMenu test was updated, but for the other APIs there was no test coverage, and it would be overkill to test that the bindings generator is working for every new feature going forward. BUG=561338 Committed: https://crrev.com/976bcb83689efff2bb1652f3073c2c9f827a0d01 Cr-Commit-Position: refs/heads/master@{#362005}

Patch Set 1 #

Patch Set 2 : fix contextmenu test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/HTMLElement/contextmenu.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLElement/contextmenu-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasPattern.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/geofencing/Geofencing.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBAlternateInterface.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConfiguration.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBEndpoint.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInterface.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476153002/1
5 years ago (2015-11-25 22:27:02 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/146301)
5 years ago (2015-11-26 00:08:33 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476153002/20001
5 years ago (2015-11-27 13:02:51 UTC) #7
philipj_slow
PTAL, and if you disagree about the testing, just say the word :)
5 years ago (2015-11-27 13:03:09 UTC) #9
haraken
LGTM
5 years ago (2015-11-27 14:46:20 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-27 14:49:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476153002/20001
5 years ago (2015-11-27 15:33:20 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 15:39:15 UTC) #16
commit-bot: I haz the power
5 years ago (2015-11-27 15:40:24 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/976bcb83689efff2bb1652f3073c2c9f827a0d01
Cr-Commit-Position: refs/heads/master@{#362005}

Powered by Google App Engine
This is Rietveld 408576698