Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1476133002:
[CQ] Add experimental bots. (Closed)
|
Created:
5 years ago by Michael Achenbach Modified:
5 years ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[CQ] Add experimental bots.
BUG=chromium:535160, chromium:561530
LOG=n
NOTRY=true
Committed: https://crrev.com/b250bec4ab249f5181c46e4ab17c978bbb59659a
Cr-Commit-Position: refs/heads/master@{#32335}
Patch Set 1 #
Total comments: 4
Messages
Total messages: 14 (7 generated)
Description was changed from ========== [CQ] Add experimental bots. BUG= ========== to ========== [CQ] Add experimental bots. BUG=chromium:535160, chromium:561530 ==========
machenbach@chromium.org changed reviewers: + sergiyb@chromium.org, tandrii@chromium.org
PTAL https://codereview.chromium.org/1476133002/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1476133002/diff/1/infra/config/cq.cfg#newcode53 infra/config/cq.cfg:53: triggered: false not entirely sure if I get the syntax right here. Is it false or False? Does the experiment_percentage make sense at all when triggered is false?
lgtm https://codereview.chromium.org/1476133002/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1476133002/diff/1/infra/config/cq.cfg#newcode53 infra/config/cq.cfg:53: triggered: false On 2015/11/25 21:13:08, Michael Achenbach (OOO) wrote: > not entirely sure if I get the syntax right here. Is it false or False? Does the > experiment_percentage make sense at all when triggered is false? yep, it's false - verified in in commit_queue code.
Description was changed from ========== [CQ] Add experimental bots. BUG=chromium:535160, chromium:561530 ========== to ========== [CQ] Add experimental bots. BUG=chromium:535160, chromium:561530 NOTRY=true ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476133002/1
Description was changed from ========== [CQ] Add experimental bots. BUG=chromium:535160, chromium:561530 NOTRY=true ========== to ========== [CQ] Add experimental bots. BUG=chromium:535160, chromium:561530 LOG=n NOTRY=true ==========
Message was sent while issue was closed.
Description was changed from ========== [CQ] Add experimental bots. BUG=chromium:535160, chromium:561530 LOG=n NOTRY=true ========== to ========== [CQ] Add experimental bots. BUG=chromium:535160, chromium:561530 LOG=n NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [CQ] Add experimental bots. BUG=chromium:535160, chromium:561530 LOG=n NOTRY=true ========== to ========== [CQ] Add experimental bots. BUG=chromium:535160, chromium:561530 LOG=n NOTRY=true Committed: https://crrev.com/b250bec4ab249f5181c46e4ab17c978bbb59659a Cr-Commit-Position: refs/heads/master@{#32335} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b250bec4ab249f5181c46e4ab17c978bbb59659a Cr-Commit-Position: refs/heads/master@{#32335}
Message was sent while issue was closed.
https://codereview.chromium.org/1476133002/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1476133002/diff/1/infra/config/cq.cfg#newcode54 infra/config/cq.cfg:54: experiment_percentage: 30 Meh - this was not useful to add. With the experiment field it seems to ignore the triggered value. Or did I get the meaning of it wrong??? CQ now _does_ trigger this bot with 30%. I thought false here means it shouldn't. E.g. this: https://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/...
Message was sent while issue was closed.
https://codereview.chromium.org/1476133002/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1476133002/diff/1/infra/config/cq.cfg#newcode54 infra/config/cq.cfg:54: experiment_percentage: 30 On 2015/11/26 13:45:57, Michael Achenbach (OOO) wrote: > Meh - this was not useful to add. With the experiment field it seems to ignore > the triggered value. Or did I get the meaning of it wrong??? > > CQ now _does_ trigger this bot with 30%. I thought false here means it > shouldn't. E.g. this: > https://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/... Ah, yes, sorry i didn't get this yesterday :(( If you want experimental, then i guess you should just make sure CQ-triggered build triggers your experimental builder, but don't tell CQ about that at all. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
