Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: src/hydrogen-instructions.h

Issue 14761010: Parallel compilation bug: LCallNewArray dereferenced a handle unnecessarily. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Renamed field Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2334 matching lines...) Expand 10 before | Expand all | Expand 10 after
2345 DECLARE_CONCRETE_INSTRUCTION(CallNew) 2345 DECLARE_CONCRETE_INSTRUCTION(CallNew)
2346 }; 2346 };
2347 2347
2348 2348
2349 class HCallNewArray: public HCallNew { 2349 class HCallNewArray: public HCallNew {
2350 public: 2350 public:
2351 HCallNewArray(HValue* context, HValue* constructor, int argument_count, 2351 HCallNewArray(HValue* context, HValue* constructor, int argument_count,
2352 Handle<JSGlobalPropertyCell> type_cell) 2352 Handle<JSGlobalPropertyCell> type_cell)
2353 : HCallNew(context, constructor, argument_count), 2353 : HCallNew(context, constructor, argument_count),
2354 type_cell_(type_cell) { 2354 type_cell_(type_cell) {
2355 elements_kind_ = static_cast<ElementsKind>(
2356 Smi::cast(type_cell->value())->value());
2355 } 2357 }
2356 2358
2357 Handle<JSGlobalPropertyCell> property_cell() const { 2359 Handle<JSGlobalPropertyCell> property_cell() const {
2358 return type_cell_; 2360 return type_cell_;
2359 } 2361 }
2360 2362
2363 ElementsKind elements_kind() const { return elements_kind_; }
2364
2361 DECLARE_CONCRETE_INSTRUCTION(CallNewArray) 2365 DECLARE_CONCRETE_INSTRUCTION(CallNewArray)
2362 2366
2363 private: 2367 private:
2368 ElementsKind elements_kind_;
2364 Handle<JSGlobalPropertyCell> type_cell_; 2369 Handle<JSGlobalPropertyCell> type_cell_;
2365 }; 2370 };
2366 2371
2367 2372
2368 class HCallRuntime: public HCall<1> { 2373 class HCallRuntime: public HCall<1> {
2369 public: 2374 public:
2370 HCallRuntime(HValue* context, 2375 HCallRuntime(HValue* context,
2371 Handle<String> name, 2376 Handle<String> name,
2372 const Runtime::Function* c_function, 2377 const Runtime::Function* c_function,
2373 int argument_count) 2378 int argument_count)
(...skipping 4148 matching lines...) Expand 10 before | Expand all | Expand 10 after
6522 virtual bool IsDeletable() const { return true; } 6527 virtual bool IsDeletable() const { return true; }
6523 }; 6528 };
6524 6529
6525 6530
6526 #undef DECLARE_INSTRUCTION 6531 #undef DECLARE_INSTRUCTION
6527 #undef DECLARE_CONCRETE_INSTRUCTION 6532 #undef DECLARE_CONCRETE_INSTRUCTION
6528 6533
6529 } } // namespace v8::internal 6534 } } // namespace v8::internal
6530 6535
6531 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6536 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698