Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 14761010: Parallel compilation bug: LCallNewArray dereferenced a handle unnecessarily. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Renamed field Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4181 matching lines...) Expand 10 before | Expand all | Expand 10 after
4192 } 4192 }
4193 4193
4194 4194
4195 void LCodeGen::DoCallNewArray(LCallNewArray* instr) { 4195 void LCodeGen::DoCallNewArray(LCallNewArray* instr) {
4196 ASSERT(ToRegister(instr->constructor()).is(r1)); 4196 ASSERT(ToRegister(instr->constructor()).is(r1));
4197 ASSERT(ToRegister(instr->result()).is(r0)); 4197 ASSERT(ToRegister(instr->result()).is(r0));
4198 ASSERT(FLAG_optimize_constructed_arrays); 4198 ASSERT(FLAG_optimize_constructed_arrays);
4199 4199
4200 __ mov(r0, Operand(instr->arity())); 4200 __ mov(r0, Operand(instr->arity()));
4201 __ mov(r2, Operand(instr->hydrogen()->property_cell())); 4201 __ mov(r2, Operand(instr->hydrogen()->property_cell()));
4202 Object* cell_value = instr->hydrogen()->property_cell()->value(); 4202 ElementsKind kind = instr->hydrogen()->elements_kind();
4203 ElementsKind kind = static_cast<ElementsKind>(Smi::cast(cell_value)->value());
4204 if (instr->arity() == 0) { 4203 if (instr->arity() == 0) {
4205 ArrayNoArgumentConstructorStub stub(kind); 4204 ArrayNoArgumentConstructorStub stub(kind);
4206 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 4205 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
4207 } else if (instr->arity() == 1) { 4206 } else if (instr->arity() == 1) {
4208 ArraySingleArgumentConstructorStub stub(kind); 4207 ArraySingleArgumentConstructorStub stub(kind);
4209 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 4208 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
4210 } else { 4209 } else {
4211 ArrayNArgumentsConstructorStub stub(kind); 4210 ArrayNArgumentsConstructorStub stub(kind);
4212 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr); 4211 CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
4213 } 4212 }
(...skipping 1795 matching lines...) Expand 10 before | Expand all | Expand 10 after
6009 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize)); 6008 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize));
6010 __ ldr(result, FieldMemOperand(scratch, 6009 __ ldr(result, FieldMemOperand(scratch,
6011 FixedArray::kHeaderSize - kPointerSize)); 6010 FixedArray::kHeaderSize - kPointerSize));
6012 __ bind(&done); 6011 __ bind(&done);
6013 } 6012 }
6014 6013
6015 6014
6016 #undef __ 6015 #undef __
6017 6016
6018 } } // namespace v8::internal 6017 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698