Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1476093004: Split paint server related measurements from SVG1DOM counter (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
Reviewers:
Ilya Sherman, fs
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split paint server related measurements from SVG1DOM counter Create a SVG1DOMPaintServer UseCounter to measure all paint server related SVG DOM functionality. The assumption we want to test is that the paint server related SVG DOM has really low usage. BUG=415074 Committed: https://crrev.com/b7d2afd53f9b008866849f088be056537f0b9de8 Cr-Commit-Position: refs/heads/master@{#361963}

Patch Set 1 #

Patch Set 2 : Update histograms.xml #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGradientElement.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLinearGradientElement.idl View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPatternElement.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRadialGradientElement.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStopElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476093004/1
5 years ago (2015-11-26 12:18:21 UTC) #3
davve
5 years ago (2015-11-26 12:18:32 UTC) #5
fs
lgtm That XML file?
5 years ago (2015-11-26 12:55:35 UTC) #6
davve
5 years ago (2015-11-26 13:12:10 UTC) #8
Ilya Sherman
histograms.xml lgtm
5 years ago (2015-11-26 20:51:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476093004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476093004/40001
5 years ago (2015-11-27 07:27:30 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-27 08:55:57 UTC) #14
commit-bot: I haz the power
5 years ago (2015-11-27 08:56:47 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b7d2afd53f9b008866849f088be056537f0b9de8
Cr-Commit-Position: refs/heads/master@{#361963}

Powered by Google App Engine
This is Rietveld 408576698