[Media Router] Only keep track of toolbar MediaRouterAction in MediaRouterDialogControllerImpl.

[Media Router] Only keep track of toolbar MediaRouterAction in MediaRouterDialogControllerImpl.

From some previous miscommunication, we assumed there was only one MediaRouterAction for each browser window instance. This is right and wrong -- there is only one MediaRouterAction for the toolbar, but there can be MediaRouterActions created and destroyed every time the overflow menu is opened. This meant that we were initially setting |action_| in MediaRouterDialogControllerImpl with the (intended) toolbar MediaRouterAction. Every time we open the overflow menu (click on wrench/hotdog icon), |action_| would be reset to a MediaRouterAction that's destroyed when the overflow menu is closed.

This change makes it such that we only keep track of the toolbar MediaRouterAction, which will always be the first MediaRouterAction that is created when the browser is opened.

BUG=531578
Committed: https://crrev.com/879ad12d519f2a50671e999e5a2c2459db0d9495
Cr-Commit-Position: refs/heads/master@{#362522}

[apacible, 2015-11-25 18:30:57]

Description was changed from

==========
fix wrench menu

BUG=
==========

to

==========
[Media Router] Only keep track of toolbar MediaRouterAction in
MediaRouterDialogControllerImpl.



BUG=531578
==========

[apacible, 2015-11-25 18:30:57]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2015-11-25 18:42:57]

Description was changed from

==========
[Media Router] Only keep track of toolbar MediaRouterAction in
MediaRouterDialogControllerImpl.



BUG=531578
==========

to

==========
[Media Router] Only keep track of toolbar MediaRouterAction in
MediaRouterDialogControllerImpl.

From some previous miscommunication, we assumed there was only one
MediaRouterAction for each browser window instance. This is right and wrong --
there is only one MediaRouterAction for the toolbar, but there can be
MediaRouterActions created and destroyed every time the overflow menu is opened.
This meant that we were initially setting |action_| in
MediaRouterDialogControllerImpl with the (intended) toolbar MediaRouterAction.
Every time we open the overflow menu (click on wrench/hotdog icon), |action_|
would be reset to a MediaRouterAction that's destroyed when the overflow menu is
closed.

This change makes it such that we only keep track of the toolbar
MediaRouterAction, which will always be the first MediaRouterAction that is
created when the browser is opened.

BUG=531578
==========

[apacible, 2015-11-25 18:45:11]

PTAL, thanks!

[imcheng, 2015-12-01 18:34:38]

lgtm

IMO, ideally we should know for a given MediaRouterAction whether it is created
for the toolbar or the overflow menu, then only have the one created for the
toolbar call into MediaRouterDialogControllerImpl. That will be more robust if
the toolbar initialization order were to change.

[apacible, 2015-12-01 19:17:33]

> IMO, ideally we should know for a given MediaRouterAction whether it is
created
> for the toolbar or the overflow menu, then only have the one created for the
> toolbar call into MediaRouterDialogControllerImpl. That will be more robust if
> the toolbar initialization order were to change.

SGTM - I have an idea of how to get this information and will work on this
between other tasks.

[apacible, 2015-12-01 19:17:42]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2015-12-01 19:18:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476053002/1

[commit-bot: I haz the power, 2015-12-01 19:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 19:39:02]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[apacible, 2015-12-01 21:33:04]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2015-12-01 21:35:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476053002/1

[commit-bot: I haz the power, 2015-12-01 22:12:22]

Description was changed from

==========
[Media Router] Only keep track of toolbar MediaRouterAction in
MediaRouterDialogControllerImpl.

From some previous miscommunication, we assumed there was only one
MediaRouterAction for each browser window instance. This is right and wrong --
there is only one MediaRouterAction for the toolbar, but there can be
MediaRouterActions created and destroyed every time the overflow menu is opened.
This meant that we were initially setting |action_| in
MediaRouterDialogControllerImpl with the (intended) toolbar MediaRouterAction.
Every time we open the overflow menu (click on wrench/hotdog icon), |action_|
would be reset to a MediaRouterAction that's destroyed when the overflow menu is
closed.

This change makes it such that we only keep track of the toolbar
MediaRouterAction, which will always be the first MediaRouterAction that is
created when the browser is opened.

BUG=531578
==========

to

==========
[Media Router] Only keep track of toolbar MediaRouterAction in
MediaRouterDialogControllerImpl.

From some previous miscommunication, we assumed there was only one
MediaRouterAction for each browser window instance. This is right and wrong --
there is only one MediaRouterAction for the toolbar, but there can be
MediaRouterActions created and destroyed every time the overflow menu is opened.
This meant that we were initially setting |action_| in
MediaRouterDialogControllerImpl with the (intended) toolbar MediaRouterAction.
Every time we open the overflow menu (click on wrench/hotdog icon), |action_|
would be reset to a MediaRouterAction that's destroyed when the overflow menu is
closed.

This change makes it such that we only keep track of the toolbar
MediaRouterAction, which will always be the first MediaRouterAction that is
created when the browser is opened.

BUG=531578
==========

[commit-bot: I haz the power, 2015-12-01 22:12:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-01 22:13:40]

Description was changed from

==========
[Media Router] Only keep track of toolbar MediaRouterAction in
MediaRouterDialogControllerImpl.

From some previous miscommunication, we assumed there was only one
MediaRouterAction for each browser window instance. This is right and wrong --
there is only one MediaRouterAction for the toolbar, but there can be
MediaRouterActions created and destroyed every time the overflow menu is opened.
This meant that we were initially setting |action_| in
MediaRouterDialogControllerImpl with the (intended) toolbar MediaRouterAction.
Every time we open the overflow menu (click on wrench/hotdog icon), |action_|
would be reset to a MediaRouterAction that's destroyed when the overflow menu is
closed.

This change makes it such that we only keep track of the toolbar
MediaRouterAction, which will always be the first MediaRouterAction that is
created when the browser is opened.

BUG=531578
==========

to

==========
[Media Router] Only keep track of toolbar MediaRouterAction in
MediaRouterDialogControllerImpl.

From some previous miscommunication, we assumed there was only one
MediaRouterAction for each browser window instance. This is right and wrong --
there is only one MediaRouterAction for the toolbar, but there can be
MediaRouterActions created and destroyed every time the overflow menu is opened.
This meant that we were initially setting |action_| in
MediaRouterDialogControllerImpl with the (intended) toolbar MediaRouterAction.
Every time we open the overflow menu (click on wrench/hotdog icon), |action_|
would be reset to a MediaRouterAction that's destroyed when the overflow menu is
closed.

This change makes it such that we only keep track of the toolbar
MediaRouterAction, which will always be the first MediaRouterAction that is
created when the browser is opened.

BUG=531578

Committed: https://crrev.com/879ad12d519f2a50671e999e5a2c2459db0d9495
Cr-Commit-Position: refs/heads/master@{#362522}
==========

[commit-bot: I haz the power, 2015-12-01 22:13:41]

Patchset 1 (id:??) landed as
https://crrev.com/879ad12d519f2a50671e999e5a2c2459db0d9495
Cr-Commit-Position: refs/heads/master@{#362522}