Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1476003002: Build content-type string in PasswordCredential::encodeFormData() (Closed)

Created:
5 years ago by tyoshino (SeeGerritForStatus)
Modified:
5 years ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build content-type string in PasswordCredential::encodeFormData() Rather than probing whether additionalData was URLSearchParams or FormData by looking at boundary(), just build the appropriate content-type string on encodeFormData() call. BUG=556431 R=mkwst Committed: https://crrev.com/0eb5f74a235e5410c04fe1593eb9430b07a9a429 Cr-Commit-Position: refs/heads/master@{#361840}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/RequestInit.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tyoshino (SeeGerritForStatus)
PTAL. Sorry if you've chosen to do it in RequestInit intentionally for some reason. Please ...
5 years ago (2015-11-25 14:43:05 UTC) #3
Mike West
LGTM if you'd prefer to do it this way.
5 years ago (2015-11-25 15:14:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476003002/20001
5 years ago (2015-11-26 05:36:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 07:11:19 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-26 07:12:17 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0eb5f74a235e5410c04fe1593eb9430b07a9a429
Cr-Commit-Position: refs/heads/master@{#361840}

Powered by Google App Engine
This is Rietveld 408576698