Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: mojo/message_pump/handle_watcher.h

Issue 1475983004: Revert making HandleWatcher block until no longer waiting on pipe (r285266). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update comment (undo change in r283888 Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/message_pump/handle_watcher.h
diff --git a/mojo/message_pump/handle_watcher.h b/mojo/message_pump/handle_watcher.h
index 1dc079ed6b239ba4bbba4f633ce7ed1a63185888..5bb3adb07761cb49943406beb111156205bbb375 100644
--- a/mojo/message_pump/handle_watcher.h
+++ b/mojo/message_pump/handle_watcher.h
@@ -28,7 +28,6 @@ class MOJO_MESSAGE_PUMP_EXPORT HandleWatcher {
public:
HandleWatcher();
- // The destructor implicitly stops listening. See Stop() for details.
~HandleWatcher();
// Starts listening for |handle|. This implicitly invokes Stop(). In other
@@ -43,8 +42,7 @@ class MOJO_MESSAGE_PUMP_EXPORT HandleWatcher {
MojoDeadline deadline,
const base::Callback<void(MojoResult)>& callback);
- // Stops listening. Does nothing if not in the process of listening. Blocks
- // until no longer listening on the handle.
+ // Stops listening. Does nothing if not in the process of listening.
void Stop();
private:
« no previous file with comments | « mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java ('k') | mojo/message_pump/handle_watcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698