Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1475973002: [turbofan] Introduce proper JSCreateLiteralRegExp operator. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce proper JSCreateLiteralRegExp operator. This adds a new JavaScript level operator for regexp literal creation, similar to what we already have for array and object literals. This once gets lowered to a call to the FastCloneRegExpStub always. R=mstarzinger@chromium.org Committed: https://crrev.com/8659c5d1d287177369ce179a8d0b910192d840d9 Cr-Commit-Position: refs/heads/master@{#32288}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use ReplaceWithStubCall. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -23 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 chunks +16 lines, -2 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/js-operator.cc View 3 chunks +17 lines, -4 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years ago (2015-11-25 14:15:53 UTC) #1
Benedikt Meurer
Hey Michi, Here's the create literal regexp cleanup we talked about yesterday. Please take a ...
5 years ago (2015-11-25 14:16:33 UTC) #2
Michael Starzinger
LGTM with suggestion. https://codereview.chromium.org/1475973002/diff/1/src/compiler/js-generic-lowering.cc File src/compiler/js-generic-lowering.cc (right): https://codereview.chromium.org/1475973002/diff/1/src/compiler/js-generic-lowering.cc#newcode531 src/compiler/js-generic-lowering.cc:531: Node* stub_code = jsgraph()->HeapConstant(callable.code()); Is it ...
5 years ago (2015-11-25 14:49:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475973002/20001
5 years ago (2015-11-25 14:53:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 16:50:02 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8659c5d1d287177369ce179a8d0b910192d840d9 Cr-Commit-Position: refs/heads/master@{#32288}
5 years ago (2015-11-25 16:50:25 UTC) #7
Igor Sheludko
5 years ago (2015-11-25 18:15:23 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1472423002/ by ishell@chromium.org.

The reason for reverting is: Broke "V8 Linux64 GC Stress - custom snapshot".

http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-....

Powered by Google App Engine
This is Rietveld 408576698