Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1475943003: gn: add support for clang for MIPS (Closed)

Created:
5 years ago by gordanac
Modified:
5 years ago
Reviewers:
Dirk Pranke, gordanac
CC:
chromium-reviews, petar.jovanovic, paul.l..., Sam Clegg, agrieve
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: add support for clang for MIPS This changes enables chrome for MIPS (Linux and Android) to be compiled with clang when using gn build. However, there are still few issues for build to complete successfully: - "treat_warnings_as_errors=false" must be set for both Android and Linux. - in case of Linux ldflags retreived by 'exec_script("sysroot_ld_path.py",..' are ignored by linker, which is causing link failure for 'chrome' target. BUG=gn gen for MIPS TEST=gn gen out-gn/mips --args="is_debug=false target_os=\"android\" target_cpu=\"mipsel\" is_clang=true treat_warnings_as_errors=false" ninja -C out-gn/mips chrome_public_apk Committed: https://crrev.com/af7fa747c3c2e433028103b45173c0275333abc7 Cr-Commit-Position: refs/heads/master@{#362002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -35 lines) Patch
M build/config/android/BUILD.gn View 5 chunks +25 lines, -19 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +80 lines, -16 lines 0 comments Download
M build/config/nacl/config.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
gordanac
Please take a look.
5 years ago (2015-11-25 16:05:29 UTC) #3
Dirk Pranke
lgtm. sbc, agrieve: FYI.
5 years ago (2015-11-25 19:13:54 UTC) #4
gordanac
I just realized the description of the change is misleading: gn gen is going to ...
5 years ago (2015-11-26 18:45:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475943003/1
5 years ago (2015-11-27 14:24:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 15:05:42 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-27 15:06:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af7fa747c3c2e433028103b45173c0275333abc7
Cr-Commit-Position: refs/heads/master@{#362002}

Powered by Google App Engine
This is Rietveld 408576698