Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1475933002: X87: Install ConstructNonConstructable as construct stub for non-constructables. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Install ConstructNonConstructable as construct stub for non-constructables. port 8e28e851ee8aa60f7102433454e77934b4702715 (r32223) original commit message: BUG= Committed: https://crrev.com/b4375d92bd5eb90b6a3a4105278ccfe26d3ca08b Cr-Commit-Position: refs/heads/master@{#32252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M src/x87/builtins-x87.cc View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years ago (2015-11-25 06:12:05 UTC) #2
Weiliang
lgtm
5 years ago (2015-11-25 08:18:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475933002/1
5 years ago (2015-11-25 08:19:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 08:37:35 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 08:37:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4375d92bd5eb90b6a3a4105278ccfe26d3ca08b
Cr-Commit-Position: refs/heads/master@{#32252}

Powered by Google App Engine
This is Rietveld 408576698