Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: content/browser/service_worker/embedded_worker_registry.h

Issue 147593006: Refine error code returned by ServiceWorkerVersion::StartWorker (e.g. PROCESS_NOT_FOUND etc) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_registry.h
diff --git a/content/browser/service_worker/embedded_worker_registry.h b/content/browser/service_worker/embedded_worker_registry.h
index 43efaa614d9cfad17812b6dd1de6b05007f1e666..f7c40cdf9602b9875b5b55bd4f988ff02eeccfc2 100644
--- a/content/browser/service_worker/embedded_worker_registry.h
+++ b/content/browser/service_worker/embedded_worker_registry.h
@@ -12,6 +12,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "content/common/content_export.h"
+#include "content/common/service_worker/service_worker_status_code.h"
class GURL;
@@ -41,12 +42,12 @@ class CONTENT_EXPORT EmbeddedWorkerRegistry
scoped_ptr<EmbeddedWorkerInstance> CreateWorker();
// Called from EmbeddedWorkerInstance, relayed to the child process.
- bool StartWorker(int process_id,
- int embedded_worker_id,
- int64 service_worker_version_id,
- const GURL& script_url);
- bool StopWorker(int process_id,
- int embedded_worker_id);
+ ServiceWorkerStatusCode StartWorker(int process_id,
+ int embedded_worker_id,
+ int64 service_worker_version_id,
+ const GURL& script_url);
+ ServiceWorkerStatusCode StopWorker(int process_id,
+ int embedded_worker_id);
// Called back from EmbeddedWorker in the child process, relayed via
// ServiceWorkerDispatcherHost.
@@ -70,7 +71,7 @@ class CONTENT_EXPORT EmbeddedWorkerRegistry
typedef std::map<int, IPC::Sender*> ProcessToSenderMap;
~EmbeddedWorkerRegistry();
- bool Send(int process_id, IPC::Message* message);
+ ServiceWorkerStatusCode Send(int process_id, IPC::Message* message);
// RemoveWorker is called when EmbeddedWorkerInstance is destructed.
// |process_id| could be invalid (i.e. -1) if it's not running.

Powered by Google App Engine
This is Rietveld 408576698