Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 147593006: Refine error code returned by ServiceWorkerVersion::StartWorker (e.g. PROCESS_NOT_FOUND etc) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/embedded_worker_instance.h
diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h
index 00ed7027555b333d47474bcb20b76f4269eb06ba..e55634c283adf265665f3ac0cd011ce19c092a6e 100644
--- a/content/browser/service_worker/embedded_worker_instance.h
+++ b/content/browser/service_worker/embedded_worker_instance.h
@@ -14,6 +14,7 @@
#include "base/memory/ref_counted.h"
#include "base/observer_list.h"
#include "content/common/content_export.h"
+#include "content/common/service_worker/service_worker_status_code.h"
class GURL;
@@ -50,21 +51,18 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
// Starts the worker. It is invalid to call this when the worker is
// not in STOPPED status.
- // This returns false if starting a worker fails immediately, e.g. when
- // IPC couldn't be sent to the worker or no process was available.
- bool Start(int64 service_worker_version_id,
- const GURL& script_url);
+ ServiceWorkerStatusCode Start(int64 service_worker_version_id,
+ const GURL& script_url);
// Stops the worker. It is invalid to call this when the worker is
// not in STARTING or RUNNING status.
// This returns false if stopping a worker fails immediately, e.g. when
// IPC couldn't be sent to the worker.
- bool Stop();
+ ServiceWorkerStatusCode Stop();
// Sends |message| to the embedded worker running in the child process.
- // This returns false if sending IPC fails.
// It is invalid to call this while the worker is not in RUNNING status.
- bool SendMessage(const IPC::Message& message);
+ ServiceWorkerStatusCode SendMessage(const IPC::Message& message);
// Add or remove |process_id| to the internal process set where this
// worker can be started.
« no previous file with comments | « no previous file | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698