Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: tools/telemetry/telemetry/core/platform/mac_platform_backend_unittest.py

Issue 147593004: [Telemetry] Allow --report-root-metrics to work on unsupported hardware. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/mac_platform_backend_unittest.py
diff --git a/tools/telemetry/telemetry/core/platform/mac_platform_backend_unittest.py b/tools/telemetry/telemetry/core/platform/mac_platform_backend_unittest.py
index d18573998bf1a8d2649362d708cf4e84c4c48928..dbd3ef5ff808ab08ded13b4d32bbdd656dc5851d 100644
--- a/tools/telemetry/telemetry/core/platform/mac_platform_backend_unittest.py
+++ b/tools/telemetry/telemetry/core/platform/mac_platform_backend_unittest.py
@@ -12,15 +12,15 @@ from telemetry.core import util
class MockPowermetricsUtility(
mac_platform_backend.MacPlatformBackend.PowerMetricsUtility):
- def __init__(self):
+ def __init__(self, output):
super(MockPowermetricsUtility, self).__init__()
+ self._output = output
def StartMonitoringPowerAsync(self):
pass
def StopMonitoringPowerAsync(self):
- test_data_path = os.path.join(util.GetUnittestDataDir(),
- 'powermetrics_output.output')
+ test_data_path = os.path.join(util.GetUnittestDataDir(), self._output)
return open(test_data_path, 'r').read()
class MacPlatformBackendTest(unittest.TestCase):
@@ -43,8 +43,18 @@ class MacPlatformBackendTest(unittest.TestCase):
logging.warning('Test not supported on this platform.')
return
- backend.SetPowerMetricsUtilityForTest(MockPowermetricsUtility())
+ # Supported hardware reports power samples and energy consumption.
+ backend.SetPowerMetricsUtilityForTest(MockPowermetricsUtility(
+ 'powermetrics_output.output'))
backend.StartMonitoringPowerAsync()
result = backend.StopMonitoringPowerAsync()
self.assertTrue(len(result['power_samples_mw']) > 1)
self.assertTrue(result['energy_consumption_mwh'] > 0)
+
+ # Unsupported hardware doesn't.
+ backend.SetPowerMetricsUtilityForTest(MockPowermetricsUtility(
+ 'powermetrics_output_unsupported_hardware.output'))
+ backend.StartMonitoringPowerAsync()
+ result = backend.StopMonitoringPowerAsync()
+ self.assertNotIn('power_samples_mw', result)
+ self.assertNotIn('energy_consumption_mwh', result)

Powered by Google App Engine
This is Rietveld 408576698