chrome/browser/download/download_shelf_context_menu.cc - Issue 147593002: Implement new dangerous download reporting dialog for UNCOMMON_DOWNLOAD, in Views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_shelf_context_menu.cc

Issue 147593002: Implement new dangerous download reporting dialog for UNCOMMON_DOWNLOAD, in Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/views/download/download_feedback_dialog_view.h » ('j') | chrome/browser/ui/views/download/download_feedback_dialog_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_shelf_context_menu.cc

diff --git a/chrome/browser/download/download_shelf_context_menu.cc b/chrome/browser/download/download_shelf_context_menu.cc

index bd98ff221d2904a94edc81b7d2ed6412d9328f61..2d772f47ea0167692d45202de03c181d5a78c3bd 100644

--- a/chrome/browser/download/download_shelf_context_menu.cc

+++ b/chrome/browser/download/download_shelf_context_menu.cc

@@ -350,8 +350,6 @@ ui::SimpleMenuModel* DownloadShelfContextMenu::GetMaybeMaliciousMenuModel() {

maybe_malicious_download_menu_model_.reset(new ui::SimpleMenuModel(this));

maybe_malicious_download_menu_model_->AddItemWithStringId(

- DISCARD, IDS_DOWNLOAD_MENU_DISCARD);

- maybe_malicious_download_menu_model_->AddItemWithStringId(

Peter Kasting 2014/02/04 21:56:33 How come we removed this?

felt 2014/02/04 23:37:22 Previously, the main button said "Report & Discard

KEEP, IDS_DOWNLOAD_MENU_KEEP);

maybe_malicious_download_menu_model_->AddSeparator(ui::NORMAL_SEPARATOR);

maybe_malicious_download_menu_model_->AddItemWithStringId(