Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/ui/views/download/download_item_view.h

Issue 147593002: Implement new dangerous download reporting dialog for UNCOMMON_DOWNLOAD, in Views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include fix Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/download/download_item_view.h
diff --git a/chrome/browser/ui/views/download/download_item_view.h b/chrome/browser/ui/views/download/download_item_view.h
index 4b4a9fda65a5142040ac9bf9dd9b4faa98e6410d..01cd11d11636ad4741db632068f7e00d7aa95e65 100644
--- a/chrome/browser/ui/views/download/download_item_view.h
+++ b/chrome/browser/ui/views/download/download_item_view.h
@@ -27,6 +27,7 @@
#include "base/timer/timer.h"
#include "chrome/browser/download/download_item_model.h"
#include "chrome/browser/icon_manager.h"
+#include "chrome/browser/ui/views/download/download_feedback_dialog_view.h"
#include "content/public/browser/download_item.h"
#include "content/public/browser/download_manager.h"
#include "ui/gfx/animation/animation_delegate.h"
@@ -146,10 +147,15 @@ class DownloadItemView : public views::ButtonListener,
void OpenDownload();
- // Submit the downloaded file to the safebrowsing download feedback service.
- // If true is returned, the DownloadItem and |this| have been deleted. If
- // false is returned, nothing has changed.
- bool BeginDownloadFeedback();
+ // Submits the downloaded file to the safebrowsing download feedback service.
+ // Returns whether submission was successful. On successful submission,
+ // |this| and the DownloadItem will have been deleted.
+ bool SubmitDownloadToFeedbackService();
+
+ // If the user has enabled uploading, calls SubmitDownloadToFeedbackService.
+ // Otherwise, it simply removes the DownloadItem without uploading.
+ void PossiblySubmitDownloadToFeedbackService(
+ DownloadFeedbackDialogView::DownloadReportingStatus status);
void LoadIcon();
void LoadIconIfItemPathChanged();

Powered by Google App Engine
This is Rietveld 408576698