Implement new dangerous download reporting dialog for UNCOMMON_DOWNLOAD, in Views

chrome/browser/ui/views/download/download_feedback_dialog_view.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/download/download_feedback_dialog_view.h"
+
+#include "chrome/browser/prefs/pref_service_syncable.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/views/constrained_window_views.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/views/controls/message_box_view.h"
+#include "ui/views/widget/widget.h"
+
+// static
+void DownloadFeedbackDialogView::Show(
+    gfx::NativeWindow parent_window,
+    Profile* profile,
+    const base::Callback<void(bool)>& callback) {
+  // Enforce the constraint that this dialog should only be shown if it hasn't
+  // been shown before. Uses USER_DISABLED as a safe default.

[mattm, 2014/01/27 08:03:33]

So it's intentional that if the browser is closed without selecting, it'll never
come up again?

[felt, 2014/01/27 20:06:59]

hmmm. I guess that would be bad. my concern was that closing the dialog using
the "x" or closing the window need a safe default. i'll test those cases out.

+  DCHECK(profile->GetPrefs()->
+      GetInteger(prefs::kSafeBrowsingDownloadReportingEnabled) == kNeverShown);
+  profile->GetPrefs()->
+      SetInteger(prefs::kSafeBrowsingDownloadReportingEnabled, kUserDisabled);
+  DownloadFeedbackDialogView* window = new DownloadFeedbackDialogView(
+      profile, callback);
+  CreateBrowserModalDialogViews(window, parent_window)->Show();
+}
+
+DownloadFeedbackDialogView::DownloadFeedbackDialogView(
+    Profile* profile,
+    const base::Callback<void(bool)>& callback)
+    : profile_(profile),
+      callback_(callback),
+      explanation_box_view_(NULL) {
+  title_text_ = l10n_util::GetStringUTF16(IDS_FEEDBACK_SERVICE_DIALOG_TITLE);
+  base::string16 explanation_text = l10n_util::GetStringUTF16(
+      IDS_FEEDBACK_SERVICE_DIALOG_EXPLANATION);
+  explanation_box_view_ = new views::MessageBoxView(
+      views::MessageBoxView::InitParams(explanation_text));
+  ok_button_text_ =
+      l10n_util::GetStringUTF16(IDS_FEEDBACK_SERVICE_DIALOG_OK_BUTTON_LABEL);
+  cancel_button_text_ = l10n_util::GetStringUTF16(
+      IDS_FEEDBACK_SERVICE_DIALOG_CANCEL_BUTTON_LABEL);
+}
+
+DownloadFeedbackDialogView::~DownloadFeedbackDialogView() {}
+
+int DownloadFeedbackDialogView::GetDefaultDialogButton() const {
+  return ui::DIALOG_BUTTON_CANCEL;
+}
+
+base::string16 DownloadFeedbackDialogView::GetDialogButtonLabel(
+    ui::DialogButton button) const {
+  return (button == ui::DIALOG_BUTTON_OK) ?
+      ok_button_text_ : cancel_button_text_;
+}
+
+bool DownloadFeedbackDialogView::Cancel() {
+  callback_.Run(false);
+  return true;
+}
+
+bool DownloadFeedbackDialogView::Accept() {
+  profile_->GetPrefs()->
+      SetInteger(prefs::kSafeBrowsingDownloadReportingEnabled, kUserEnabled);
+  callback_.Run(true);
+  return true;
+}
+
+ui::ModalType DownloadFeedbackDialogView::GetModalType() const {
+  return ui::MODAL_TYPE_SYSTEM;
+}
+
+base::string16 DownloadFeedbackDialogView::GetWindowTitle() const {
+  return title_text_;
+}
+
+void DownloadFeedbackDialogView::DeleteDelegate() {
+  delete this;
+}
+
+views::Widget* DownloadFeedbackDialogView::GetWidget() {
+  return explanation_box_view_->GetWidget();
+}
+
+const views::Widget* DownloadFeedbackDialogView::GetWidget() const {
+  return explanation_box_view_->GetWidget();
+}
+
+views::View* DownloadFeedbackDialogView::GetContentsView() {
+  return explanation_box_view_;
+}